Issue 24021: Add docstring to urllib.urlretrieve (original) (raw)

Created on 2015-04-21 15:43 by krichter, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
urllib_2.7.patch Daniel.Andrade.Groppe,2015-05-25 04:22 patch for 2.7 review
issue-24021.patch PeterLovett,2015-08-04 00:25 review
Messages (7)
msg241765 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-04-22 03:23
urllib.urlretrieve is already documented at https://docs.python.org/2.7/library/urllib.html#urllib.urlretrieve Can you please give us more information about your problem with the urllib.urlretrieve documentation?
msg241769 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-04-22 04:13
I suspect the complaint might be about the lack of doc string, but a more specific bug report would be nice to clarify this. $ pydoc2 urllib.urlretrieve Help on function urlretrieve in urllib: urllib.urlretrieve = urlretrieve(url, filename=None, reporthook=None, data=None, context=None) $
msg241791 - (view) Author: Karl Richter (krichter) Date: 2015-04-22 09:10
> I suspect the complaint might be about the lack of doc string Exactly. It'd be helpful to figure out the return value and the means of the function arguments in a more compact form than the referenced website docs and to have it available in the interpreter (with `help`), i.e. with docstring documentation.
msg244013 - (view) Author: Daniel Andrade Groppe (Daniel.Andrade.Groppe) * Date: 2015-05-25 04:22
Adding docstrings for urllib.urlretrieve() and urlib.cleanup() for Python 2.7.
msg247969 - (view) Author: Peter Lovett (PeterLovett) * Date: 2015-08-04 00:25
Updated patch to 3.6 urlretrieve now has a decent docstring; this patch just adds a docstring to urlcleanup.
msg247971 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-08-04 00:53
New changeset 659f5adc2354 by Robert Collins in branch '3.4': Issue #24021: docstring for urllib.urlcleanup. https://hg.python.org/cpython/rev/659f5adc2354 New changeset 6fd69aeb8a3b by Robert Collins in branch '3.5': Issue #24021: docstring for urllib.urlcleanup. https://hg.python.org/cpython/rev/6fd69aeb8a3b New changeset 43ed41cdd3c2 by Robert Collins in branch 'default': Issue #24021: docstring for urllib.urlcleanup. https://hg.python.org/cpython/rev/43ed41cdd3c2
msg247972 - (view) Author: Robert Collins (rbcollins) * (Python committer) Date: 2015-08-04 00:54
Applied to 3.4 and up. Thanks for the patch.
History
Date User Action Args
2022-04-11 14:58:15 admin set github: 68209
2015-08-04 00:54:21 rbcollins set status: open -> closednosy: + rbcollinsmessages: + resolution: fixedstage: needs patch -> resolved
2015-08-04 00:53:41 python-dev set nosy: + python-devmessages: +
2015-08-04 00:25:51 PeterLovett set files: + issue-24021.patchversions: + Python 3.6, - Python 2.7nosy: + PeterLovettmessages: +
2015-05-25 04:22:09 Daniel.Andrade.Groppe set files: + urllib_2.7.patchnosy: + Daniel.Andrade.Groppemessages: + keywords: + patch
2015-04-26 09:19:35 berker.peksag set keywords: + easytitle: document urllib.urlretrieve -> Add docstring to urllib.urlretrievestage: needs patchtype: enhancementversions: + Python 3.4, Python 3.5
2015-04-22 09:10:09 krichter set messages: +
2015-04-22 04:13:38 martin.panter set nosy: + martin.pantermessages: +
2015-04-22 03:23:46 berker.peksag set nosy: + berker.peksagmessages: +
2015-04-21 15:43:36 krichter create