Issue 24048: remove_module() needs to save/restore exception state (original) (raw)
Created on 2015-04-24 05:58 by herring, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13005 | merged | ZackerySpytz,2019-04-29 09:29 | |
| PR 20521 | merged | miss-islington,2020-05-29 19:17 |
| Messages (9) | ||
|---|---|---|
| msg241914 - (view) | Author: Davis Herring (herring) | Date: 2015-04-24 05:58 |
| import.c's remove_module() is always called with an exception set and can invoke arbitrary code via deallocation; if that code calls PyErr_Clear() (or is sensitive to PyErr_Occurred()) it will lose (or be damaged by) the preexisting exception. | ||
| msg341063 - (view) | Author: Zackery Spytz (ZackerySpytz) *  |
Date: 2019-04-29 09:30 |
| I've created a PR for this issue. | ||
| msg341905 - (view) | Author: Alyssa Coghlan (ncoghlan) *  |
Date: 2019-05-08 16:31 |
| New changeset 94a64e9cd411a87514b68082c1c437eb3b49dfb9 by Nick Coghlan (Zackery Spytz) in branch 'master': bpo-24048: Save the live exception during import.c's remove_module() (GH-13005) https://github.com/python/cpython/commit/94a64e9cd411a87514b68082c1c437eb3b49dfb9 | ||
| msg342428 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2019-05-14 04:16 |
| Can this be closed, Nick? | ||
| msg342430 - (view) | Author: Zackery Spytz (ZackerySpytz) * |
Date: 2019-05-14 04:34 |
| I think this change should be backported. | ||
| msg370329 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2020-05-29 17:48 |
| Assigning to Nick to decide if he wants to backport it to 3.7 before it's no longer possible. | ||
| msg370335 - (view) | Author: miss-islington (miss-islington) | Date: 2020-05-29 19:35 |
| New changeset 5aa40e587e63bcad22c7e196fc3559e2b5e0792b by Miss Islington (bot) in branch '3.7': bpo-24048: Save the live exception during import.c's remove_module() (GH-13005) https://github.com/python/cpython/commit/5aa40e587e63bcad22c7e196fc3559e2b5e0792b | ||
| msg370497 - (view) | Author: Zackery Spytz (ZackerySpytz) * |
Date: 2020-05-31 18:47 |
| It seems that Serhiy backported the fix. | ||
| msg372498 - (view) | Author: Alyssa Coghlan (ncoghlan) * |
Date: 2020-06-28 06:52 |
| Belatedly marking this as resolved. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:16 | admin | set | github: 68236 |
| 2020-06-28 06:52:49 | ncoghlan | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2020-05-31 18:47:10 | ZackerySpytz | set | messages: + |
| 2020-05-29 19:35:28 | miss-islington | set | messages: + |
| 2020-05-29 19:17:32 | miss-islington | set | nosy: + miss-islingtonpull_requests: + <pull%5Frequest19765> |
| 2020-05-29 17:49:12 | brett.cannon | set | nosy: - brett.cannon |
| 2020-05-29 17:48:58 | brett.cannon | set | assignee: ncoghlanmessages: + |
| 2019-05-14 04:34:31 | ZackerySpytz | set | messages: + |
| 2019-05-14 04:16:07 | brett.cannon | set | messages: + |
| 2019-05-08 16:31:28 | ncoghlan | set | messages: + |
| 2019-04-29 09:30:49 | ZackerySpytz | set | nosy: + ZackerySpytzmessages: + versions: + Python 3.7, Python 3.8, - Python 3.2, Python 3.3, Python 3.4, Python 3.5 |
| 2019-04-29 09:29:55 | ZackerySpytz | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12926> |
| 2015-04-24 14:39:35 | brett.cannon | set | nosy: + brett.cannon, ncoghlan, eric.snow |
| 2015-04-24 05:58:38 | herring | create |