Issue 24114: ctypes.utils uninitialized variable 'paths' (original) (raw)

Created on 2015-05-02 15:03 by kees, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ctypes.util-path.patch kees,2015-05-02 15:03 patch for uninitialized variable 'path' review
issue24114.patch xiang.zhang,2016-04-28 09:25 review
Messages (8)
msg242401 - (view) Author: Kees Bos (kees) * Date: 2015-05-02 15:03
In certain corner cases, the ctypes.util can raise an error for a uninitialized variable 'path' when with sunos5 the clre program exists, but fails to return valid output lines. (Also in 2.7.10rc0)
msg243288 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-05-16 00:02
I fail to see how this patch does anything. What is the actual error or traceback? Perhaps it is for “paths” (plural)?
msg243299 - (view) Author: Kees Bos (kees) * Date: 2015-05-16 08:04
Sorry, yes. It's plural: 'paths'
msg264425 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-04-28 09:25
Simply add one line to make the function theoretically more robust.
msg264426 - (view) Author: Kees Bos (kees) * Date: 2016-04-28 10:15
It's not entirely theoretical to me. I inherited some solaris boxes that cannot be properly maintained anymore and that have a clre program that dumps core. Hence no valid output and running into uninitialized 'paths'. The patch from Xiang Zhang will fix that.
msg264428 - (view) Author: Meador Inge (meador.inge) * (Python committer) Date: 2016-04-28 12:28
Xiang's patch LGTM. Given that Kees has verified it, I will apply today.
msg264577 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-05-01 03:29
New changeset 57bf7a40925f by Meador Inge in branch '2.7': Issue #24114: Fix an uninitialized variable in `ctypes.util`. https://hg.python.org/cpython/rev/57bf7a40925f New changeset db5baad7ad69 by Meador Inge in branch '3.5': Issue #24114: Fix an uninitialized variable in `ctypes.util`. https://hg.python.org/cpython/rev/db5baad7ad69 New changeset 5b5fbce1db9c by Meador Inge in branch 'default': Issue #24114: Fix an uninitialized variable in `ctypes.util`. https://hg.python.org/cpython/rev/5b5fbce1db9c
msg264578 - (view) Author: Meador Inge (meador.inge) * (Python committer) Date: 2016-05-01 03:32
Fixed. Thank y'all for the patch and help with testing.
History
Date User Action Args
2022-04-11 14:58:16 admin set github: 68302
2016-05-01 03:32:51 meador.inge set status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2016-05-01 03:29:19 python-dev set nosy: + python-devmessages: +
2016-04-28 12:28:19 meador.inge set assignee: meador.ingemessages: + stage: needs patch -> commit review
2016-04-28 10:15:37 kees set messages: +
2016-04-28 09:25:33 xiang.zhang set files: + issue24114.patchnosy: + xiang.zhangmessages: +
2016-04-25 04:19:28 berker.peksag set keywords: + easyversions: + Python 3.5, Python 3.6
2016-04-25 01:41:20 martin.panter set title: ctypes.utils uninitialized variable 'path' -> ctypes.utils uninitialized variable 'paths'type: behaviorstage: patch review -> needs patch
2015-05-16 08:04:23 kees set messages: +
2015-05-16 00:02:49 martin.panter set nosy: + martin.pantermessages: +
2015-05-05 20:48:42 ned.deily set nosy: + amaury.forgeotdarc, belopolsky, meador.ingetype: crash -> (no value)stage: patch review
2015-05-02 15:03:15 kees create