Issue 24210: Tests failed with -Werror (original) (raw)

Created on 2015-05-16 14:21 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue24210.diff berker.peksag,2015-05-16 18:41 review
Messages (11)
msg243323 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-16 14:21
$ ./python -Werror -m test.regrtest -u all -vv == CPython 3.5.0a4+ (default:5342fad7cd59+, May 16 2015, 15:55:16) [GCC 4.8.2] Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/runpy.py", line 170, in _run_module_as_main "__main__", mod_spec) File "/home/serhiy/py/cpython/Lib/runpy.py", line 85, in _run_code exec(code, run_globals) File "/home/serhiy/py/cpython/Lib/test/regrtest.py", line 1589, in main_in_temp_cwd() File "/home/serhiy/py/cpython/Lib/test/regrtest.py", line 1564, in main_in_temp_cwd main() File "/home/serhiy/py/cpython/Lib/test/regrtest.py", line 602, in main print("== ", platform.platform(aliased=True), File "/home/serhiy/py/cpython/Lib/platform.py", line 1441, in platform distname, distversion, distid = dist('') File "/home/serhiy/py/cpython/Lib/platform.py", line 378, in dist PendingDeprecationWarning, stacklevel=2) PendingDeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 and will be removed in Python 3.7
msg243325 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-05-16 15:04
This is caused by issue 1322. I'll fix it.
msg243336 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-05-16 17:24
New changeset 6181146842ba by Berker Peksag in branch 'default': Issue #24210: Silence a PendingDeprecationWarning warning in platform.platform(). https://hg.python.org/cpython/rev/6181146842ba
msg243337 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-05-16 17:25
Thanks Serhiy.
msg243338 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-16 17:33
test_platform is failed. ====================================================================== ERROR: test_dist (test.test_platform.PlatformTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/test/test_platform.py", line 239, in test_dist res = platform.dist() File "/home/serhiy/py/cpython/Lib/platform.py", line 380, in dist PendingDeprecationWarning, stacklevel=2) PendingDeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 and will be removed in Python 3.7 ====================================================================== ERROR: test_linux_distribution_encoding (test.test_platform.PlatformTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/test/test_platform.py", line 308, in test_linux_distribution_encoding distname, version, distid = platform.linux_distribution() File "/home/serhiy/py/cpython/Lib/platform.py", line 305, in linux_distribution PendingDeprecationWarning, stacklevel=2) PendingDeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 and will be removed in Python 3.7 ----------------------------------------------------------------------
msg243339 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-16 17:36
And test_ssl. $ ./python -Werror -m test.regrtest -vv test_ssl == CPython 3.5.0a4+ (default:08829230079b+, May 16 2015, 19:19:38) [GCC 4.8.2] == Linux-3.13.0-53-generic-i686-athlon-with-debian-jessie-sid little-endian == hash algorithm: siphash24 32bit == /home/serhiy/py/cpython/build/test_python_9027 Testing with flags: sys.flags(debug=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, verbose=0, bytes_warning=0, quiet=0, hash_randomization=1, isolated=0) [1/1] test_ssl test test_ssl crashed -- Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/test/regrtest.py", line 1280, in runtest_inner test_runner() File "/home/serhiy/py/cpython/Lib/test/test_ssl.py", line 3303, in test_main plat = func() File "/home/serhiy/py/cpython/Lib/platform.py", line 305, in linux_distribution PendingDeprecationWarning, stacklevel=2) PendingDeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 and will be removed in Python 3.7 1 test failed: test_ssl
msg243345 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-05-16 17:58
Interesting, I ran the test suite twice before commit the patch. I will take a look, thanks!
msg243353 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-05-16 18:41
Here is a patch. An unrelated failure: $ ./python -Werror -m test test_slice [1/1] test_slice test test_slice failed -- Traceback (most recent call last): File "/home/berker/projects/cpython/default/Lib/test/test_slice.py", line 82, in test_hash self.assertRaises(TypeError, slice(5).__hash__) File "/home/berker/projects/cpython/default/Lib/unittest/case.py", line 711, in assertRaises return context.handle('assertRaises', args, kwargs) File "/home/berker/projects/cpython/default/Lib/unittest/case.py", line 153, in handle DeprecationWarning, 3) DeprecationWarning: callable is None
msg243357 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-05-16 19:02
The patch LGTM. But what to do with this code after 3.7? And why not to do this right now? > An unrelated failure: Ah, this is . Thank you for reporting this.
msg243365 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-05-16 20:21
New changeset e73182301a61 by Berker Peksag in branch 'default': Issue #24210: Silence more PendingDeprecationWarning warnings in tests. https://hg.python.org/cpython/rev/e73182301a61
msg243366 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-05-16 20:24
> But what to do with this code after 3.7? And why not to do this right now? It's on my TODO list, but I'll probably won't have time to work on in it before beta 1. Thanks for the review!
History
Date User Action Args
2022-04-11 14:58:16 admin set github: 68398
2015-05-16 20:24:05 berker.peksag set status: open -> closedresolution: fixedmessages: + stage: resolved
2015-05-16 20:21:33 python-dev set messages: +
2015-05-16 19:02:26 serhiy.storchaka set messages: +
2015-05-16 18:41:43 berker.peksag set files: + issue24210.diffkeywords: + patchmessages: +
2015-05-16 17:58:37 berker.peksag set messages: +
2015-05-16 17:36:28 serhiy.storchaka set messages: +
2015-05-16 17:33:47 serhiy.storchaka set status: closed -> openresolution: fixed -> (no value)messages: + stage: resolved -> (no value)
2015-05-16 17:25:45 berker.peksag set status: open -> closedresolution: fixedmessages: + stage: resolved
2015-05-16 17:24:47 python-dev set nosy: + python-devmessages: +
2015-05-16 15:04:59 berker.peksag set assignee: berker.peksagmessages: +
2015-05-16 14:52:02 berker.peksag set nosy: + berker.peksag
2015-05-16 14:21:40 serhiy.storchaka create