Issue 24953: ICC and version should be in COMPILER string when built with ICC on Windows (original) (raw)

Issue24953

Created on 2015-08-28 20:51 by zach.ware, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg249297 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2015-08-28 20:51
This patch makes the compiler portion of the sys.version string look something like "[ICC v.1500 32-bit (Intel) with MSC v.1500 CRT]" when Python is built with ICC. This format keeps distutils happy without having to change its parsing of the version string to decide which compiler to use for extensions, while making it possible to tell which compiler was used to build Python.
msg249298 - (view)	Author: Steve Dower (steve.dower) *	Date: 2015-08-28 21:16
LGTM
msg249313 - (view)	Author: Roundup Robot (python-dev)	Date: 2015-08-29 05:13
New changeset 3639520c3fe9 by Zachary Ware in branch '2.7': Issue #24953: Include ICC version in sys.version string when bulit with ICC on Windows https://hg.python.org/cpython/rev/3639520c3fe9 New changeset ca88db01bb51 by Zachary Ware in branch '3.5': Issue #24953: Include ICC version in sys.version string when bulit with ICC on Windows https://hg.python.org/cpython/rev/ca88db01bb51 New changeset 1633fe209375 by Zachary Ware in branch 'default': Closes #24953: Merge with 3.5 https://hg.python.org/cpython/rev/1633fe209375
msg249314 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2015-08-29 05:18
Thanks for the review, Steve!