Issue 25071: Windows installer requires TargetDir parameter when installing quietly (original) (raw)

Issue25071

Created on 2015-09-11 16:10 by steve.dower, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
25071_1.patch steve.dower,2015-09-11 17:58 review
Messages (6)
msg250476 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-11 16:10
If you run the installer without UI and without specifying an installation path, it will not install. For example: C:\> python-3.5.0rc4-amd64-webinstall.exe /passive The workaround is to specify TargetPath: C:\> python-3.5.0rc4-amd64-webinstall.exe /passive TargetPath="C:\Python35_x64" However, this workaround should not be necessary. We should use the default path based on the InstallAllUsers setting (false by default).
msg250477 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-11 16:12
Adding Larry, as this either needs a fix or a prominent release note for 3.5.0 (or we document the bug in the docs). I *think* the fix will be fairly simple and constrained entire to one file. Should have something ready later today.
msg250480 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-11 17:58
Patch attached. PR for 3.5.0 at: https://bitbucket.org/larry/cpython350/pull-requests/25/issue-25071-windows-installer-should-not/diff
msg250486 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-09-11 18:25
Pull request approved. Hopefully the last one for 3.5.0! Please forward-merge.
msg250487 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-09-11 18:31
New changeset da8f2767b6cc by Steve Dower in branch '3.5': Issue #25071: Windows installer should not require TargetDir parameter when installing quietly https://hg.python.org/cpython/rev/da8f2767b6cc New changeset bb7363b8b50e by Steve Dower in branch 'default': Issue #25071: Windows installer should not require TargetDir parameter when installing quietly https://hg.python.org/cpython/rev/bb7363b8b50e
msg250488 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-11 18:32
I hope so too :)
History
Date User Action Args
2022-04-11 14:58:20 admin set github: 69258
2015-09-11 18:32:09 steve.dower set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2015-09-11 18:31:51 python-dev set nosy: + python-devmessages: +
2015-09-11 18:25:08 larry set messages: +
2015-09-11 17:58:11 steve.dower set files: + 25071_1.patchkeywords: + patchmessages: + stage: needs patch -> patch review
2015-09-11 16:12:32 steve.dower set nosy: + larrymessages: +
2015-09-11 16:10:26 steve.dower set nosy: + takluyver
2015-09-11 16:10:01 steve.dower create