Issue 25249: Unneeded and unsafe mkstemp replacement in test_subprocess.py (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/69436
classification
| Title: | Unneeded and unsafe mkstemp replacement in test_subprocess.py | ||
|---|---|---|---|
| Type: | Stage: | resolved | |
| Components: | Tests | Versions: | Python 3.6, Python 3.4, Python 3.5, Python 2.7 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | Nosy List: | berker.peksag, nirs, python-dev | |
| Priority: | normal | Keywords: | patch |
Created on 2015-09-27 19:40 by nirs, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| 0001-Remove-unneeded-and-unsafe-mkstemp-replacement.patch | nirs,2015-09-27 19:40 | Patch fixing this issue | |
| 0001-Remove-unneeded-and-unsafe-mkstemp-replacement-2.7.patch | nirs,2015-09-27 20:02 | Patch for 2.7 |
| Messages (4) | ||
|---|---|---|
| msg251720 - (view) | Author: Nir Soffer (nirs) * | Date: 2015-09-27 19:40 |
| The module define unsafe replacement if tempfile.mkstemp is not available. This function is available in both master and 2.7 branches. | ||
| msg251757 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2015-09-28 10:34 |
| New changeset 23f4daf7a211 by Berker Peksag in branch '3.4': Issue #25249: Remove unneeded mkstemp helper in test_subprocess https://hg.python.org/cpython/rev/23f4daf7a211 New changeset 4cd3027ffc34 by Berker Peksag in branch '3.5': Issue #25249: Remove unneeded mkstemp helper in test_subprocess https://hg.python.org/cpython/rev/4cd3027ffc34 New changeset e863c8760501 by Berker Peksag in branch 'default': Issue #25249: Remove unneeded mkstemp helper in test_subprocess https://hg.python.org/cpython/rev/e863c8760501 | ||
| msg251761 - (view) | Author: Roundup Robot (python-dev) |
Date: 2015-09-28 12:38 |
| New changeset ea91991c7db5 by Berker Peksag in branch '2.7': Issue #25249: Remove unneeded mkstemp helper in test_subprocess https://hg.python.org/cpython/rev/ea91991c7db5 | ||
| msg251762 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2015-09-28 12:39 |
| Thanks for the patch, Nir. Just fixed a small typo(fd -> f) in the 2.7 patch. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:21 | admin | set | github: 69436 |
| 2015-09-28 12:39:18 | berker.peksag | set | status: open -> closedversions: + Python 3.4, Python 3.5nosy: + berker.peksagmessages: + resolution: fixedstage: resolved |
| 2015-09-28 12:38:02 | python-dev | set | messages: + |
| 2015-09-28 10:34:26 | python-dev | set | nosy: + python-devmessages: + |
| 2015-09-27 20:02:54 | nirs | set | files: + 0001-Remove-unneeded-and-unsafe-mkstemp-replacement-2.7.patch |
| 2015-09-27 19:40:34 | nirs | create |