Issue 26184: Add versionchanged note for error when create_module() is not defined by loaders (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/70372

classification

Title: Add versionchanged note for error when create_module() is not defined by loaders
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.7, Python 3.6

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Mariatta, brett.cannon, docs@python, eric.snow, mbussonn, ncoghlan
Priority: normal Keywords: easy

Created on 2016-01-22 22:31 by brett.cannon, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 277 closed Mariatta,2017-02-24 20:08
PR 320 merged Mariatta,2017-02-26 15:38
PR 325 merged Mariatta,2017-02-26 21:08
PR 326 merged Mariatta,2017-02-26 21:25
Messages (8)
msg258840 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-01-22 22:31
As explained in https://docs.python.org/3/reference/import.html#loaders, as of Python 3.6 an error is to be raised when a loader defines exec_module() but not create_module(). Probably should raise a TypeError.
msg288502 - (view) Author: Matthias Bussonnier (mbussonn) * Date: 2017-02-24 03:59
should be closed by #28026, it now raises an ImportError. I think this can be closed. Unless one want to change the text in Starting in Python 3.6 it will be an error > Starting in Python 3.6 it will be an error To use the past tense.
msg288505 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2017-02-24 07:07
That should actually be a versionchanged note now - converting this to an easy documentation issue to cover that change.
msg288614 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-02-26 21:39
Merged and backported to 3.6. Closing this issue :) Thanks.
msg290373 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-03-24 23:39
New changeset 7e4897a2fb91e49f131a42ed6de88b5185f7dea8 by Mariatta in branch '3.6': bpo-26184: import.rst: Improve versionchanged note (GH-325) (GH-326) https://github.com/python/cpython/commit/7e4897a2fb91e49f131a42ed6de88b5185f7dea8
msg290374 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-03-24 23:39
New changeset 1f5639c77f736c18fb5a85b4a1850121e25c788e by Mariatta in branch 'master': bpo-26184: import.rst: Improve versionchanged note (GH-325) https://github.com/python/cpython/commit/1f5639c77f736c18fb5a85b4a1850121e25c788e
msg290381 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-03-24 23:40
New changeset deea29e61e61f0e216bff3f0ca008f5ee231793f by Mariatta in branch '3.6': bpo-26184: import.rst: Improve versionchanged note (GH-277) (#320) https://github.com/python/cpython/commit/deea29e61e61f0e216bff3f0ca008f5ee231793f
msg290386 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-03-24 23:41
New changeset 6b4a5f45e2df524174a97832571c82c76a3d424a by Mariatta in branch 'master': bpo-26184: import.rst: Improve versionchanged note (GH-277) https://github.com/python/cpython/commit/6b4a5f45e2df524174a97832571c82c76a3d424a
History
Date User Action Args
2022-04-11 14:58:26 admin set github: 70372
2017-03-24 23:41:35 Mariatta set messages: +
2017-03-24 23:40:43 Mariatta set messages: +
2017-03-24 23:39:23 Mariatta set messages: +
2017-03-24 23:39:05 Mariatta set messages: +
2017-02-26 21:39:41 Mariatta set status: open -> closednosy: + Mariattamessages: + resolution: fixedstage: needs patch -> resolved
2017-02-26 21:25:59 Mariatta set pull_requests: + <pull%5Frequest286>
2017-02-26 21:08:47 Mariatta set pull_requests: + <pull%5Frequest285>
2017-02-26 15:38:53 Mariatta set pull_requests: + <pull%5Frequest281>
2017-02-24 20:08:28 Mariatta set pull_requests: + <pull%5Frequest247>
2017-02-24 07:07:11 ncoghlan set assignee: docs@pythoncomponents: + Documentation, - Interpreter Coretitle: raise an error when create_module() is not defined by exec_module() is for loaders -> Add versionchanged note for error when create_module() is not defined by loaderskeywords: + easynosy: + docs@pythonversions: + Python 3.7messages: + stage: test needed -> needs patch
2017-02-24 03:59:36 mbussonn set nosy: + mbussonnmessages: +
2016-01-22 22:31:00 brett.cannon create