1. It doesn't have the Reference 4 used anywhere in the doc. 2. The `if` condition is not properly ended in the Programming Recommendation section. 3. Apart from that few grammatical changes are necessary I believe.
I can't really comment on the grammar changes, but the rest looks good to me. This is not very smooth, in both versions: -Consistency within one module or function is most important. +Consistency within one module or function is the most important thing. -But most importantly: know when to be inconsistent -- sometimes the -style guide just doesn't apply. When in doubt, use your best +But more importantly: know when to be inconsistent -- sometimes the +style guide just isn't applicable. When in doubt, use your best (Consistency is already *most* important, but then comes something *more* important?)
-Consistency within one module or function is most important. +Consistency within one module or function is the most important. You left out "thing" from the patch; is that intended?
On Feb 22, 2016, at 02:20 PM, Georg Brandl wrote: >Georg Brandl added the comment: > >-Consistency within one module or function is most important. >+Consistency within one module or function is the most important. > >You left out "thing" from the patch; is that intended? Yes.
History
Date
User
Action
Args
2022-04-11 14:58:27
admin
set
github: 70596
2016-02-22 16:29:09
barry
set
messages: +
2016-02-22 14:20:48
georg.brandl
set
messages: +
2016-02-22 14:05:52
python-dev
set
status: open -> closednosy: + python-devmessages: + resolution: fixedstage: resolved
