| msg65733 - (view) |
Author: Thomas Heller (theller) *  |
Date: 2008-04-24 18:07 |
| Zachary Pincus posted a message about this cyclic reference in ctypes CFunctionType objects. The reference has the problem that these objects are cleaned up later than expected. The attached patch fixes this problem by removing the cyclic reference. |
|
|
| msg65738 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2008-04-24 18:37 |
| Can you please elaborate your (apparent) concerns about this patch? IOW, why did you not check it in? |
|
|
| msg65739 - (view) |
Author: Thomas Heller (theller) * |
Date: 2008-04-24 18:45 |
| > Can you please elaborate your (apparent) concerns about this patch? IOW, > why did you not check it in? I have no concerns about the patch, and I am currently committing it. I'm uploading so that I can points others to it, and (hopefully) to test it before some alpha release. It is part of my workflow: I develop a patch, test it locally, upload it and eventually commit it sonner or later, sometimes changing things depending on feedback I get. |
|
|
| msg65741 - (view) |
Author: Thomas Heller (theller) * |
Date: 2008-04-24 18:57 |
| Fixed in trunk and py3k, committed as rev 62481 (trunk), rev 62484 (py3k). I'll leave this open until the decision about backporting to release25-maint is made. |
|
|
| msg65775 - (view) |
Author: Thomas Heller (theller) * |
Date: 2008-04-25 09:39 |
| >> Can you please elaborate your (apparent) concerns about this patch? IOW, >> why did you not check it in? > > I have no concerns about the patch, and I am currently committing it. > I'm uploading so that I can points others to it, and (hopefully) to test > it before some alpha release. > > It is part of my workflow: I develop a patch, test it locally, upload it > and eventually commit it sonner or later, sometimes changing things > depending on feedback I get. Martin, are there any problems with this approach? |
|
|
| msg65801 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2008-04-25 17:48 |
| > Martin, are there any problems with this approach? No, it's fine. I was just puzzled. |
|
|
| msg65806 - (view) |
Author: Thomas Heller (theller) * |
Date: 2008-04-25 19:55 |
| Also fixed in release25-maint, rev 62504. |
|
|