Issue 27055: python fails to run zipapp when zip contains comments (original) (raw)

python fails to run zipapp when zip contains comments when zip archive downloaded from github it contains tip hash in comment.

Python 3.5.1 (v3.5.1:37a07cee5969, Dec 6 2015, 01:38:48) [MSC v.1900 32 bit (Intel)] on win32

example:

import zipfile


if __name__ == '__main__':
    with open('__main__.py', "w") as m:
      m.write("print('hello')")
    

    zipf = zipfile.ZipFile('zipapp_bad.zip', 'w', zipfile.ZIP_DEFLATED)
    #add zip comment
    zipf.comment=b"123321"
    zipf.write("__main__.py")
    zipf.close()

    zipf = zipfile.ZipFile('zipapp_good.zip', 'w', zipfile.ZIP_DEFLATED)
    zipf.write("__main__.py")
    zipf.close()

D:\pywork\zip>python zipapp_good.zip hello

D:\pywork\zip>python zipapp_bad.zip File "zipapp_bad.zip", line 1 PK♥♦¶ ^ SyntaxError: invalid syntax