Issue 2725: Handle ASDLSyntaxErrors gracefully (original) (raw)
Issue2725
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/46977
classification
Title: | Handle ASDLSyntaxErrors gracefully | ||
---|---|---|---|
Type: | behavior | Stage: | |
Components: | Build | Versions: | Python 3.0 |
process
Status: | closed | Resolution: | fixed |
---|---|---|---|
Dependencies: | Superseder: | ||
Assigned To: | georg.brandl | Nosy List: | georg.brandl, thomaslee |
Priority: | normal | Keywords: | patch |
Created on 2008-04-30 12:08 by thomaslee, last changed 2022-04-11 14:56 by admin. This issue is now closed.
Files | |||
---|---|---|---|
File name | Uploaded | Description | Edit |
fix-asdl-errors.patch | thomaslee,2008-04-30 12:07 | A patch to correct the handling of ASDL syntax errors |
Messages (3) | ||
---|---|---|
msg65999 - (view) | Author: Thomas Lee (thomaslee) ![]() |
Date: 2008-04-30 12:06 |
The current code in Parser/asdl.py doesn't handle syntax errors very well. A minor problem to be sure, since the net result is the same (i.e. build fails), but the error message being displayed is entirely unhelpful to the developer. The attached patch will display the error message as was seemingly intended. This probably affects earlier versions (including python-trunk), but I haven't tested. | ||
msg66020 - (view) | Author: Georg Brandl (georg.brandl) * ![]() |
Date: 2008-04-30 20:16 |
Some comments: - Since you check for a false mod before calling check(), the check in check() will not be reached. - The error print seems to be already in trunk. | ||
msg85893 - (view) | Author: Georg Brandl (georg.brandl) * ![]() |
Date: 2009-04-12 11:34 |
Committed a similar patch in r71505. |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:56:33 | admin | set | github: 46977 |
2009-04-12 11:34:21 | georg.brandl | set | status: open -> closedresolution: fixedmessages: + |
2009-04-07 22:52:39 | georg.brandl | set | assignee: georg.brandl |
2008-04-30 20:16:19 | georg.brandl | set | nosy: + georg.brandlmessages: + |
2008-04-30 12:08:04 | thomaslee | create |