Issue 2744: Fix test_cProfile - Python tracker (original) (raw)

Created on 2008-05-02 23:15 by benjamin.peterson, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (14)
msg66131 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-05-02 23:15
test_cProfile has been disabled in Py3k for a while now. It should be fixed before release.
msg66168 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-05-03 20:01
A key thing to realize is that test_cprofile has heavily changed in 2.6 compared to what is currently disabled in 3.0.
msg68016 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2008-06-11 20:50
I will try to fix this one with profile/cProfile merge.
msg70481 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-07-31 02:15
Alexandre, are you still computerless?
msg70667 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2008-08-03 22:42
Not anymore! :-)
msg72417 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-09-03 21:19
So is this going to be a 3.1 issue or a 3.0 one? If it's the former then it should not be a release blocker. But if is going to be for 3.0 then the version list is wrong.
msg72470 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2008-09-04 02:49
I guess since this hasn't been done by now, it's not going to get done for 3.0, so I'm lowering the priority on it.
msg74391 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-10-06 21:21
Done in r66817.
msg74395 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2008-10-06 22:06
Have you verified the numbers? They don't look right to me. The problem is the 2nd argument of cProfile's constructor has a different semantic meaning than the one for profile.py. For profile.py, it is used to set the "bias" (I presume it means the overhead) of the profiler. But for cProfile, it's the unit (in seconds?) of timer used. Personally, I have no idea which semantic should be preferred. So perhaps, the best thing to do for now is remove the second argument from the cls.profilerclass() call in test_profile.ProfileTest: class ProfileTest: ... def do_profiling(cls): ... prof = cls.profilerclass(timer, 0.001) ...
msg74396 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-10-06 22:08
No, I didn't look too hard at it; I just got it scraping along, so I can forward port a fix for it. I'll reopen this, so you can take more action, so you wish. :)
msg74397 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2008-10-06 22:10
Unassigning myself as I don't have the time to fix this properly.
msg109475 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-07 14:01
Is there anybody who can run with this as it's been in limbo for over two years?
msg111996 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-29 20:34
Nobody has responded to so I'll close unless there are any objections.
msg111999 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2010-07-29 20:39
> I'll close unless there are any objections. Yes, I object! :) If there's still a bug present, it seems inappropriate to close this issue. So as a first step, someone needs to look at this closely to determine whether there *is* still a problem that needs fixing. (It's not clear to me at the moment whether that's true.)
History
Date User Action Args
2022-04-11 14:56:33 admin set github: 46993
2012-11-17 17:06:14 brett.cannon set status: open -> closedresolution: out of date
2010-07-29 20:39:28 mark.dickinson set status: pending -> opennosy: + mark.dickinsonmessages: +
2010-07-29 20:34:22 BreamoreBoy set status: open -> pendingpriority: high -> normalmessages: +
2010-07-07 14:01:23 BreamoreBoy set nosy: + BreamoreBoymessages: + versions: + Python 2.7, Python 3.2
2008-11-06 03🔞27 benjamin.peterson set priority: critical -> high
2008-10-06 22:10:39 alexandre.vassalotti set assignee: alexandre.vassalotti ->
2008-10-06 22:10:31 alexandre.vassalotti set messages: +
2008-10-06 22:08:30 benjamin.peterson set status: closed -> openresolution: fixed -> (no value)messages: +
2008-10-06 22:06:07 alexandre.vassalotti set messages: +
2008-10-06 21:21:07 benjamin.peterson set status: open -> closedresolution: fixedmessages: +
2008-09-04 02:49:44 barry set priority: release blocker -> criticalnosy: + barrymessages: +
2008-09-03 21:19:30 brett.cannon set messages: +
2008-08-24 19:01:06 nnorwitz set priority: critical -> release blocker
2008-08-21 14:27:29 benjamin.peterson set versions: + Python 3.1, - Python 3.0
2008-08-03 22:42:37 alexandre.vassalotti set messages: +
2008-07-31 02:15:34 benjamin.peterson set messages: +
2008-06-11 20:50:47 alexandre.vassalotti set assignee: alexandre.vassalottimessages: + nosy: + alexandre.vassalotti
2008-05-03 20:01:51 brett.cannon set nosy: + brett.cannonmessages: +
2008-05-02 23:15:09 benjamin.peterson create