| msg272326 - (view) |
Author: Stéphane Wirtel (matrixise) *  |
Date: 2016-08-10 11:23 |
| I use Exuberant Ctags 5.8 on my Fedora 24, and this version does not accept the '-t' argument, as defined in the 'tags' target of the Makefile. |
|
|
| msg272328 - (view) |
Author: SilentGhost (SilentGhost) *  |
Date: 2016-08-10 12:25 |
| For the record, according to http://ctags.sourceforge.net/news.html that option was removed in version 2.0.1 released over 18 years ago. |
|
|
| msg272337 - (view) |
Author: Stéphane Wirtel (matrixise) * |
Date: 2016-08-10 15:31 |
| yep, maybe in this case, we can accept my patch ;-) |
|
|
| msg272338 - (view) |
Author: Stéphane Wirtel (matrixise) * |
Date: 2016-08-10 15:32 |
| and in my first description, I have just forgotten to indicate this argument was not supported by the last version of ctags. @SilentGhost confirms this point ;-) (since 1998). |
|
|
| msg272340 - (view) |
Author: Evelyn Mitchell (Evelyn Mitchell) * |
Date: 2016-08-10 16:12 |
| It looks to me the patch only removes the -t argument, as required. |
|
|
| msg272346 - (view) |
Author: Stéphane Wirtel (matrixise) * |
Date: 2016-08-10 17:27 |
| Ned, BSD cTags does not support -t The -t option is a no-op for compatibility with previous versions of ctags that did not create tags for typedefs, enums, structs and unions by default. https://www.freebsd.org/cgi/man.cgi?query=ctags&sektion=1#end Gnu GLOBAL aka gtags does not support -t stephane@sg1 /t/g/gtags> ./gtags -t ./gtags: invalid option -- 't' Usage: gtags [-ciIOqvw][-d tag-file][-f file][dbpath] stephane@sg1 /t/g/gtags> ./gtags --version gtags (GNU GLOBAL) 6.5.4 Copyright (c) 2016 Tama Communications Corporation License GPLv3+: GNU GPL version 3 or later And Exuberant Tags does not support -t Maybe we can remove it ? Or I can propose a patch where we try to support the '-t' parameter but this one is not defined, just for the compatibility. Thank you, Stephane |
|
|
| msg272365 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2016-08-10 19:30 |
| It seems that there are a bunch of different ctags and ctags-like programs out there. I don't use ctags myself (nor the "make tags" build step) and I don't know how other programs use the tags file it produces so I don't really have an opinion one way or the other. All I can say is that, after a quick check on the two systems I'm most familiar with, each with a different version of ctags (GNU ctags on Debian and a version of BSD tags on OS X), for both the -t option is functional and the resulting tags files with and without the -t step in the Makefile recipe are different. It may be that the extra entries produced by the -t step are just redundant. So, without spending more time on this right now, I would be willing to apply a patch that ignores an error if -t is missing. Otherwise, if someone is certain there is no loss of functionality on our supported platforms by removing the -t step, they are welcome to apply the existing patch. |
|
|
| msg272921 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2016-08-17 11:53 |
| Thanks Stéphane for your fix. |
|
|
| msg272922 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2016-08-17 11:56 |
| Oops, I didn't mention the issue number in the change. changeset: 102724:8455902b3b8e tag: tip user: Victor Stinner <victor.stinner@gmail.com> date: Wed Aug 17 13:51:52 2016 +0200 files: Makefile.pre.in description: "make tags": remove -t option of ctags The option was kept for backward compatibility, but it was completly removed recently. Patch written by Stéphane Wirtel. |
|
|
| msg272923 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2016-08-17 11:59 |
| New changeset cbe87a9a0cf2 by Victor Stinner in branch 'default': Fix "make tags": set locale to C to call sort https://hg.python.org/cpython/rev/cbe87a9a0cf2 |
|
|
| msg272924 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2016-08-17 12:04 |
| New changeset ed95e9ca2699 by Victor Stinner in branch '3.5': Issue #27726: Fix "make tags" https://hg.python.org/cpython/rev/ed95e9ca2699 |
|
|