Issue 27788: platform module's version number doesn't match its docstring (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/71975
classification
| Title: | platform module's version number doesn't match its docstring | ||
|---|---|---|---|
| Type: | Stage: | resolved | |
| Components: | Library (Lib) | Versions: | Python 3.7, Python 3.6 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | lemburg | Nosy List: | berker.peksag, brett.cannon, lemburg |
| Priority: | normal | Keywords: |
Created on 2016-08-17 16:10 by brett.cannon, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 246 | merged | mbussonn,2017-02-23 06:32 | |
| PR 341 | merged | berker.peksag,2017-02-27 14:27 |
| Messages (7) | ||
|---|---|---|
| msg272964 - (view) | Author: Brett Cannon (brett.cannon) *  |
Date: 2016-08-17 16:10 |
| Not sure if it's worth keeping the version number around, but ATM the module has __version__ set to 1.0.7 while the docstring mentions a 1.0.8. | ||
| msg272984 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2016-08-17 20:56 |
| That must have been an oversight. __version__ should read '0.8.0'. | ||
| msg288503 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-02-24 04:50 |
| Perhaps it's now time to drop that __version__ attribute in 3.7? We've removed the __version__ attribute from the email module in issue 22508. | ||
| msg288516 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2017-02-24 10:45 |
| The purpose of __version__ in the platform module is to be able to use it with other Python as well (and then detect which version is available in applications). So I think it's good to keep it around. | ||
| msg288518 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2017-02-24 10:49 |
| Hmm, not sure why the merge is not showing up on the ticket. Here's the link: https://github.com/python/cpython/commit/6059ce45aa96f52fa0150e68ea655fbfdc25609a | ||
| msg290367 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-03-24 23:37 |
| New changeset bb59d89ceeb1abfb4d73c7fc60b534e4464adf35 by Berker Peksag in branch '3.6': bpo-27788 : synchronise platform.py version number (#246) (#341) https://github.com/python/cpython/commit/bb59d89ceeb1abfb4d73c7fc60b534e4464adf35 | ||
| msg290413 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2017-03-24 23:48 |
| New changeset 6059ce45aa96f52fa0150e68ea655fbfdc25609a by Marc-Andre Lemburg (Matthias Bussonnier) in branch 'master': bpo-27788 : synchronise platform.py version number (#246) https://github.com/python/cpython/commit/6059ce45aa96f52fa0150e68ea655fbfdc25609a |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:34 | admin | set | github: 71975 |
| 2017-03-24 23:48:44 | lemburg | set | messages: + |
| 2017-03-24 23:37:08 | berker.peksag | set | messages: + |
| 2017-02-27 14:27:30 | berker.peksag | set | pull_requests: + <pull%5Frequest295> |
| 2017-02-24 10:49:26 | lemburg | set | messages: + |
| 2017-02-24 10:48:27 | lemburg | set | status: open -> closedassignee: lemburgresolution: fixedstage: patch review -> resolved |
| 2017-02-24 10:45:52 | lemburg | set | messages: + |
| 2017-02-24 04:50:20 | berker.peksag | set | nosy: + berker.peksagmessages: + stage: patch review |
| 2017-02-23 07:48:25 | Mariatta | set | versions: + Python 3.7 |
| 2017-02-23 06:32:21 | mbussonn | set | pull_requests: + <pull%5Frequest211> |
| 2016-08-17 20:56:48 | lemburg | set | messages: + |
| 2016-08-17 16:10:58 | brett.cannon | create |