Issue 27807: Prevent site-packages .pth files from causing test_site failure: test_site.test_startup_imports() failure (original) (raw)
Issue27807
Created on 2016-08-19 22:05 by Rosuav, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| no-site-packages-in-test.patch | Rosuav,2016-08-19 22:06 | review |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 19060 | merged | vstinner,2020-03-18 15:17 | |
| PR 19089 | closed | miss-islington,2020-03-20 13:02 | |
| PR 19090 | merged | vstinner,2020-03-20 13:04 | |
| PR 19093 | merged | miss-islington,2020-03-20 14:10 |
| Messages (8) | ||
|---|---|---|
| msg273160 - (view) | Author: Chris Angelico (Rosuav) * | Date: 2016-08-19 22:05 |
| Having matplotlib installed globally causes test_site to fail, due to the .pth file importing types. The point of the test is to monitor startup dependencies (and thus time) for the core interpreter and standard library, not third-party libraries, so having a test failure due to a .pth is not overly useful. Solution suggested by Steve Dower: hack out all .pth handling during this one test, leaving everything else unchanged. | ||
| msg273165 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2016-08-19 23:27 |
| I think hitting adventurous users like Chris who locally compile and test with this failure is wrong. There is no core dev 'site' expert, so I picked 'testing'. | ||
| msg364523 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-03-18 15:00 |
| Fedora and RHEL downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1814392 | ||
| msg364526 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-03-18 15:14 |
| I marked bpo-35691 as a duplicate of this issue. | ||
| msg364536 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-03-18 17:27 |
| New changeset d18de46117d661a4acaf2380cc5ebb1cf6a000e9 by Victor Stinner in branch 'master': bpo-27807: Skip test_site.test_startup_imports() if pth file (GH-19060) https://github.com/python/cpython/commit/d18de46117d661a4acaf2380cc5ebb1cf6a000e9 | ||
| msg364668 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-03-20 14:10 |
| New changeset ba26bf30940f4347fedcf8ebc374c6e2dc375afa by Victor Stinner in branch '3.8': [3.8] bpo-27807: Skip test_site.test_startup_imports() if pth file (GH-19060) (GH-19090) https://github.com/python/cpython/commit/ba26bf30940f4347fedcf8ebc374c6e2dc375afa | ||
| msg364672 - (view) | Author: miss-islington (miss-islington) | Date: 2020-03-20 14:28 |
| New changeset 6056b7b84f2f77e2c3b49a18cfebe061fc23a08a by Miss Islington (bot) in branch '3.7': [3.8] bpo-27807: Skip test_site.test_startup_imports() if pth file (GH-19060) (GH-19090) https://github.com/python/cpython/commit/6056b7b84f2f77e2c3b49a18cfebe061fc23a08a | ||
| msg364673 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-03-20 14:32 |
| The issue is now fixed in 3.7, 3.8 and master branches. Thanks Chris Angelico for the bug report. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:35 | admin | set | github: 71994 |
| 2020-03-20 14:32:53 | vstinner | set | status: open -> closedversions: + Python 3.7, Python 3.8, Python 3.9, - Python 3.6messages: + resolution: fixedstage: patch review -> resolved |
| 2020-03-20 14:28:02 | miss-islington | set | messages: + |
| 2020-03-20 14:10:37 | miss-islington | set | pull_requests: + <pull%5Frequest18453> |
| 2020-03-20 14:10:20 | vstinner | set | messages: + |
| 2020-03-20 13:04:25 | vstinner | set | pull_requests: + <pull%5Frequest18450> |
| 2020-03-20 13:02:57 | miss-islington | set | nosy: + miss-islingtonpull_requests: + <pull%5Frequest18449> |
| 2020-03-18 17:27:51 | vstinner | set | messages: + |
| 2020-03-18 15:17:14 | vstinner | set | stage: patch reviewpull_requests: + <pull%5Frequest18413> |
| 2020-03-18 15:15:26 | vstinner | set | title: Prevent site-packages .pth files from causing test_site failure -> Prevent site-packages .pth files from causing test_site failure: test_site.test_startup_imports() failure |
| 2020-03-18 15:14:59 | vstinner | set | messages: + |
| 2020-03-18 15:14:44 | vstinner | link | issue35691 superseder |
| 2020-03-18 15:00:02 | vstinner | set | nosy: + vstinnermessages: + |
| 2016-08-19 23:27:59 | terry.reedy | set | nosy: + ezio.melotti, terry.reedy, michael.foordmessages: + |
| 2016-08-19 22:06:20 | Rosuav | set | files: + no-site-packages-in-test.patchkeywords: + patch |
| 2016-08-19 22:05:23 | Rosuav | create |