Issue 27909: Py_INCREF(NULL) in _imp.create_builtin (original) (raw)

Issue27909

Created on 2016-08-31 09:26 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
create_builtin.patch xiang.zhang,2016-08-31 09:26 review
Messages (3)
msg274007 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-08-31 09:26
Just as the patch shows, when PyErr_Occurred() returns true mod is NULL, then Py_INCREF(mod) will crash. Replace it with Py_XINCREF.
msg274033 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-08-31 15:44
New changeset caf547c9e589 by Raymond Hettinger in branch '3.5': Issue #27909: Fix INCREF for possible NULL value https://hg.python.org/cpython/rev/caf547c9e589
msg274034 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2016-08-31 15:45
Thanks for the patch.
History
Date User Action Args
2022-04-11 14:58:35 admin set github: 72096
2016-08-31 16:02:51 SilentGhost set stage: resolved
2016-08-31 15:45:37 rhettinger set status: open -> closednosy: + rhettingermessages: + assignee: rhettingerresolution: fixed
2016-08-31 15:44:35 python-dev set nosy: + python-devmessages: +
2016-08-31 09:26:29 xiang.zhang create