Issue 28008: PEP 530, asynchronous comprehensions implementation (original) (raw)

Issue28008

Created on 2016-09-07 21:15 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
async_comp_1.patch yselivanov,2016-09-07 21:15
asyncomp.patch yselivanov,2016-09-09 16:05 review
Messages (7)
msg274897 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-09-07 21:15
This patch is supposed to be committed after issue #28003.
msg275358 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-09 17:36
New changeset cf91a929b81a by Yury Selivanov in branch 'default': Issue #28008: Implement PEP 530 -- asynchronous comprehensions. https://hg.python.org/cpython/rev/cf91a929b81a
msg275359 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-09-09 17:36
Committed. Thank you Victor for the review.
msg275361 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-09-09 17:58
You are not done yet :-) http://buildbot.python.org/all/builders/s390x%20SLES%203.x/builds/1762/steps/test/logs/stdio ====================================================================== FAIL: test_files (test.test_tools.test_unparse.DirectoryTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 297, in test_files self.check_roundtrip(source) File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 132, in check_roundtrip self.assertASTEqual(ast1, ast2) File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 124, in assertASTEqual self.assertEqual(ast.dump(ast1), ast.dump(ast2)) AssertionError: 'Modu[156588 chars]sync=1)]))], decorator_list=[], returns=None),[36372 chars]])])' != 'Modu[156588 chars]sync=0)]))], decorator_list=[], returns=None),[36372 chars]])])' ----------------------------------------------------------------------
msg275384 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-09 18:48
New changeset 223c134af5a1 by Yury Selivanov in branch 'default': Issue #28008: Fix test_unparse https://hg.python.org/cpython/rev/223c134af5a1
msg275385 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-09-09 18:49
Should be fixed now.
msg275416 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-09-09 20:05
Build bots are green now, closing this.
History
Date User Action Args
2022-04-11 14:58:36 admin set github: 72195
2016-09-11 17:43:06 ned.deily set priority: release blocker -> status: open -> closedresolution: fixed
2016-09-09 20:05:49 yselivanov set messages: +
2016-09-09 18:49:16 yselivanov set messages: +
2016-09-09 18:48:48 python-dev set messages: +
2016-09-09 17:58:37 vstinner set status: closed -> openresolution: fixed -> (no value)messages: +
2016-09-09 17:36:45 yselivanov set status: open -> closedresolution: fixedstage: patch review -> resolved
2016-09-09 17:36:34 yselivanov set messages: +
2016-09-09 17:36:13 python-dev set nosy: + python-devmessages: +
2016-09-09 16:05:27 yselivanov set files: + asyncomp.patch
2016-09-07 21:15:27 yselivanov create