Issue 28035: make buildbottest when configured --with-optimizations can cause a recompile? (original) (raw)

Issue28035

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/72222

classification

process

Created on 2016-09-09 04:55 by gregory.p.smith, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg275255 - (view)	Author: Gregory P. Smith (gregory.p.smith) *	Date: 2016-09-09 04:55
See the logs from this build for example: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.x/builds/4 Notice how the test stdio shows it recompiling all over again. This is happening even on a "successful" test: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.5/builds/1/steps/test/logs/stdio
msg275399 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-09-09 19:24
New changeset 852b0f536791 by Gregory P. Smith in branch '3.5': Fix make buildbottest to not re-trigger a profile-opt build. . https://hg.python.org/cpython/rev/852b0f536791 New changeset 914a81781291 by Gregory P. Smith in branch 'default': Fix make buildbottest to not re-trigger a profile-opt build. . https://hg.python.org/cpython/rev/914a81781291
msg275400 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-09-09 19:25
New changeset 951f0de11a01 by Gregory P. Smith in branch '2.7': Fix make buildbottest to not re-trigger a profile-opt build. . https://hg.python.org/cpython/rev/951f0de11a01
msg275401 - (view)	Author: Gregory P. Smith (gregory.p.smith) *	Date: 2016-09-09 19:27
having fixed this that way... I wonder why we bother having the buildbottest target depend on a compilation target at all. buildbots always do a separate compile and test phase, we should really use a make target that assumes the compile phase has finished. as is, i still see it try to recompile a couple things in make buildbottest which could mean it isn't quite testing what we wanted from the 'compile' phase...