Issue 28050: test_traceback is broken by new CALL_FUNCTION* opcodes (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/72237

classification

process

Created on 2016-09-09 19:11 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (6)
msg275396 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-09-09 19:11
I skipped the failing tests just to be able to push my FASTCALL changes before Python 3.6 feature freeze. I opened this issue to not forget to fix it.
msg275403 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-09-09 19:28
New changeset a77756e480c2 by Victor Stinner in branch 'default': Rework CALL_FUNCTION* opcodes https://hg.python.org/cpython/rev/a77756e480c2
msg275453 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-09-09 21:37
Serhiy proposed a fix in the issue #27213 (starting at callfunc-10.patch).
msg282438 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-12-05 17:07
Oh, this issue was already fixed, thanks Serhiy :-) changeset: 103659:51b635e81958 user: Serhiy Storchaka <storchaka@gmail.com> date: Mon Sep 12 00:52:40 2016 +0300 files: Include/abstract.h Lib/dis.py Lib/test/test_extcall.py Lib/test/test_traceback.py Objects/abstract.c Objects/methodobject.c Python/ceval.c Python/compile.c Python/importlib.h Python/imp description: Issue #27213: Fixed different issues with reworked CALL_FUNCTION* opcodes. * BUILD_TUPLE_UNPACK and BUILD_MAP_UNPACK_WITH_CALL no longer generated with single tuple or dict. * Restored more informative error messages for incorrect var-positional and var-keyword arguments. * Removed code duplications in _PyEval_EvalCodeWithName(). * Removed redundant runtime checks and parameters in _PyStack_AsDict(). * Added a workaround and enabled previously disabled test in test_traceback. * Removed dead code from the dis module.
msg282440 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2016-12-05 17:19
It is rather worked around.
msg282441 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-12-05 17:27
Serhiy Storchaka added the comment: > It is rather worked around. The test pass, the change looks good to me. I don't think that it's still worth it to keep the issue open ;-)