Issue 28079: Update typing and test typing from python/typing repo (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/72266

classification

Title: Update typing and test typing from python/typing repo
Type: enhancement Stage:
Components: Library (Lib) Versions:

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, levkivskyi, python-dev
Priority: normal Keywords: patch

Created on 2016-09-11 16:51 by levkivskyi, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
typing-patch.diff levkivskyi,2016-09-11 16:51 review
typing-patch-3.6.diff levkivskyi,2016-09-11 17:16 review
Messages (7)
msg275809 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-09-11 16:51
Here is the patch for 3.5
msg275810 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-09-11 17:00
I have noticed that some code could be simplified, since it is backward-compatible even with 3.2, but I think it is easiest to keep the source here in sync with what is on python/typing.
msg275811 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2016-09-11 17:09
Um, if I apply this to 3.5 it works, but if I then merge forward to 3.6 (default) I get merge conflicts. I'll have to sort that out tonight.
msg275812 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-09-11 17:16
I could guess this is because some changes have been already integrated by patch that implemented PEP 526. If this would help here is a separate patch that should apply cleanly to 3.6
msg275874 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-11 22:31
New changeset b66e0856ab24 by Guido van Rossum in branch 'default': Issue #28079: Update typing and test typing from python/typing repo. https://hg.python.org/cpython/rev/b66e0856ab24
msg275875 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-11 22:35
New changeset cf7da3fd6450 by Guido van Rossum in branch '3.5': Issue #28079: Update typing and test typing from python/typing repo. https://hg.python.org/cpython/rev/cf7da3fd6450
msg275876 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2016-09-11 22:39
Thanks! All set.
msg275877 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2016-09-11 22:40
Thanks! All set.
msg275878 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2016-09-11 22:40
Thanks! All set.
History
Date User Action Args
2022-04-11 14:58:36 admin set github: 72266
2016-09-11 22:41:30 gvanrossum set status: open -> closedresolution: fixedmessages: +
2016-09-11 22:41:30 gvanrossum set status: open -> openresolution: (no value)messages: +
2016-09-11 22:39:55 gvanrossum set status: open -> openresolution: (no value)messages: +
2016-09-11 22:35:59 python-dev set messages: +
2016-09-11 22:31:48 python-dev set nosy: + python-devmessages: +
2016-09-11 17:16:13 levkivskyi set files: + typing-patch-3.6.diffmessages: +
2016-09-11 17:09:30 gvanrossum set messages: +
2016-09-11 17:00:54 levkivskyi set messages: +
2016-09-11 16:54:24 levkivskyi set type: enhancementcomponents: + Library (Lib)
2016-09-11 16:51:28 levkivskyi create