Issue 28089: asyncio: Document that TCP_NODELAY is now used by default (original) (raw)

Created on 2016-09-12 01:33 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue28089.patch Mariatta,2016-12-06 03:27 review
issue28089v2.patch Mariatta,2016-12-06 03:49 review
Messages (14)
msg282459 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-12-05 20:16
This is marked as a release blocker but, since it's just a doc change, I'm not going to hold 3.6.0 for it. It would be nice to get it in, though.
msg282466 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-05 21:55
Yury: I don't understand your issue, can you please elaborate? Do you mean that the default value of the TCP_NODELAY changed in Python 3.6? Otherwise, why do you consider it as a release blocker? The Python 3.6 release must be blocked by a TCP flag? Really?
msg282470 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2016-12-05 22:12
The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5.
msg282471 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-05 22:15
> The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5. Ah, it's a change in _asyncio_, ok. I missed that from the issue title, so I changed the title.
msg282495 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2016-12-06 03:27
I added the following to Doc/library/asyncio-protocol.rst .. versionchanged:: 3.6.0 The socket option TCP_NODELAY is now set by default. Let me know if this patch works.
msg282497 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-12-06 03:44
+.. versionchanged:: 3.6.0 3.6.0 -> 3.6 + The socket option TCP_NODELAY is now set by default. TCP_NODELAY -> ``TCP_NODELAY``
msg282498 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2016-12-06 03:49
Thanks, Berker :) Updated.
msg282510 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-06 10:00
New changeset 726308cfe3b5 by Victor Stinner in branch '3.6': catch_warnings() calls showwarning() if overriden https://hg.python.org/cpython/rev/726308cfe3b5
msg282511 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-06 10:03
New changeset 150d36dbe3ba by Victor Stinner in branch '3.6': warnings: Fix the issue number https://hg.python.org/cpython/rev/150d36dbe3ba
msg283050 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-12-12 21:37
Yury, look good to you?
msg283053 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-12 21:45
New changeset 853e3f4d6cd9 by Yury Selivanov in branch '3.6': Issue #28089: Document TCP_NODELAY in asyncio https://hg.python.org/cpython/rev/853e3f4d6cd9 New changeset 0d209cc7ffdc by Yury Selivanov in branch 'default': Merge 3.6 (issue #28089) https://hg.python.org/cpython/rev/0d209cc7ffdc
msg283054 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-12-12 21:46
> Yury, look good to you? Yes; committed the patch with a small addition. Thanks, Mariatta!
msg283377 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-16 07:44
New changeset dfd1019f75f9 by Yury Selivanov in branch '3.6': Issue #28089: Document TCP_NODELAY in asyncio https://hg.python.org/cpython/rev/dfd1019f75f9
msg283384 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-12-16 07:54
[cherrypicked for 3.6.0rc2]
History
Date User Action Args
2022-04-11 14:58:36 admin set github: 72276
2016-12-16 07:54:15 ned.deily set priority: deferred blocker -> messages: +
2016-12-16 07:44:47 python-dev set messages: +
2016-12-12 21:46:32 yselivanov set status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2016-12-12 21:45:29 python-dev set messages: +
2016-12-12 21:37:21 ned.deily set stage: patch review -> commit reviewmessages: + versions: + Python 3.7
2016-12-06 10:03:16 python-dev set messages: +
2016-12-06 10:00:40 python-dev set nosy: + python-devmessages: +
2016-12-06 03:49:45 Mariatta set files: + issue28089v2.patchmessages: +
2016-12-06 03:44:12 berker.peksag set nosy: + berker.peksagmessages: + stage: needs patch -> patch review
2016-12-06 03:27:33 Mariatta set files: + issue28089.patchkeywords: + patchmessages: +
2016-12-05 22:15:03 vstinner set messages: +
2016-12-05 22:14:11 vstinner set title: Document TCP_NODELAY by default -> asyncio: Document that TCP_NODELAY is now used by default
2016-12-05 22:12:16 Mariatta set messages: +
2016-12-05 21:55:51 vstinner set messages: +
2016-12-05 20:16:44 ned.deily set priority: release blocker -> deferred blockermessages: +
2016-10-01 21:39:21 Mariatta set nosy: + Mariatta
2016-09-12 01:33:48 yselivanov create