Issue 28139: Misleading Indentation in C source code (original) (raw)

Issue28139

Created on 2016-09-14 00:49 by franciscouzo, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg276367 - (view)	Author: Francisco Couzo (franciscouzo) *	Date: 2016-09-14 00:49
Fixed the warnings that appear when compiling 2.7 with -Wmisleading-indentation (Included in -Wall since GCC 6). Kinda related, though I don't think there would be too much interest in fixing it (all the tabs in Python's C source): $ find . -name '*.c' -print0 | xargs -0 grep -R $'\t'	wc -l 10407
msg276375 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-09-14 04:49
New changeset 4d91f5c2ef99 by Benjamin Peterson in branch '2.7': fix misleading indentation (closes #28139) https://hg.python.org/cpython/rev/4d91f5c2ef99
msg276657 - (view)	Author: Martin Panter (martin.panter) *	Date: 2016-09-16 01:39
. I found more messed up indentation looking through Antoine’s large “untabify” commit r81029. These don’t trigger compiler warnings, but I think it may be worth restoring them.
msg276687 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2016-09-16 09:28
In general LGTM. This is not cosmetic change, this fixes readability of the sources. But I left few comments on Rietveld.
msg276777 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-09-17 08:02
New changeset a2bfec367cef by Martin Panter in branch '2.7': Issue #28139: Fix messed up indentation https://hg.python.org/cpython/rev/a2bfec367cef New changeset 0e2a891639dd by Martin Panter in branch '3.5': Issue #28139: Fix messed up indentation https://hg.python.org/cpython/rev/0e2a891639dd New changeset 1e052a70a70a by Martin Panter in branch '3.6': Issue #28139: Merge indentation fixes from 3.5 into 3.6 https://hg.python.org/cpython/rev/1e052a70a70a New changeset c49084a28969 by Martin Panter in branch 'default': Issue #28139: Merge indentation fixes from 3.6 https://hg.python.org/cpython/rev/c49084a28969