original ) (raw ) Issue28194
Created on 2016-09-18 09:12 by xiang.zhang , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Messages (4)
msg276875 - (view) Author: Xiang Zhang (xiang.zhang) *
Date: 2016-09-18 09:12
The proposed patch cleans up some unnecessary parts in dict implementation especially NULL checks in lookup functions. There are four states a DictKeyEntry can be. Only in unused(empty) and dummy states me_key can be NULL. So NULL checks in used and pending states are not needed.
msg276892 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2016-09-18 14:30
LGTM if address methane's comment.
msg276894 - (view) Author: Xiang Zhang (xiang.zhang) *
Date: 2016-09-18 14:56
Apply methane's comment, preserving the comment.
msg277444 - (view) Author: Roundup Robot (python-dev)
Date: 2016-09-26 18:30
New changeset 1d41d741bb5b by Serhiy Storchaka in branch '3.6': Issue #28194 : Clean up some checks in dict implementation. https://hg.python.org/cpython/rev/1d41d741bb5b New changeset b83a70afca39 by Serhiy Storchaka in branch 'default': Issue #28194 : Clean up some checks in dict implementation. https://hg.python.org/cpython/rev/b83a70afca39
History
Date
User
Action
Args
2022-04-11 14:58:37
admin
set
github: 72381
2016-09-26 18:31:36
serhiy.storchaka
set
status: open -> closedresolution: fixedstage: patch review -> resolved
2016-09-26 18:30:23
python-dev
set
nosy: + python-dev messages: +
2016-09-26 08:57:39
serhiy.storchaka
set
assignee: serhiy.storchaka
2016-09-18 14:56:41
xiang.zhang
set
files: + dict_clean_up_v2.patch messages: +
2016-09-18 14:30:49
serhiy.storchaka
set
messages: +
2016-09-18 09:12:17
xiang.zhang
create
