Issue 28221: Unused indata in test_ssl.ThreadedTests.test_asyncore_server (original) (raw)
Issue28221
Created on 2016-09-21 01:35 by martin.panter, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Messages (4) | ||
|---|---|---|
| msg277085 - (view) | Author: Martin Panter (martin.panter) *  |
Date: 2016-09-21 01:35 |
| In r62273 (Apr 2008), method testAsyncoreServer() was added to the py3k branch with indata="FOO\n". In r64578 (Jun 2008), this test method was added to the Py 2 branch, but with indata = "TEST MESSAGE of mixed case\n". Later, r80598 added the mixed case line to the Py 3 branch, but it is not used because the original FOO line overwrites it. Then revision 221a1f9155e2 backported the Py 3 code to 2.7. So now both versions include the mixed case line but neither use it. I haven’t investigated, but I presume either the mixed case version would test more stuff and should be enabled, or it would be overkill and should be dropped in favour of the simpler line. | ||
| msg277087 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-09-21 04:12 |
| Actually in the Py 3 branch, I found an earlier revision that added indata="FOO\n": r59506 (Dec 2007). Anyway, the server in the test case just does a simple lower() call on the data, so I think the simpler FOO line may be fine on its own. | ||
| msg277112 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2016-09-21 09:01 |
| Thanks for your investigation. | ||
| msg277308 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-09-24 03:35 |
| New changeset 4a1e1715efc3 by Martin Panter in branch '2.7': Issue #28221: Remove unused assignment from test_asyncore_server() https://hg.python.org/cpython/rev/4a1e1715efc3 New changeset 97ff9934ad2d by Martin Panter in branch '3.5': Issue #28221: Remove unused assignment from test_asyncore_server() https://hg.python.org/cpython/rev/97ff9934ad2d New changeset d8d047217da1 by Martin Panter in branch '3.6': Issue #28221: Merge SSL test cleanup from 3.5 into 3.6 https://hg.python.org/cpython/rev/d8d047217da1 New changeset 65e83846ed51 by Martin Panter in branch 'default': Issue #28221: Merge SSL test cleanup from 3.6 https://hg.python.org/cpython/rev/65e83846ed51 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:37 | admin | set | github: 72408 |
| 2016-09-24 05:29:58 | martin.panter | set | status: open -> closedresolution: fixedstage: needs patch -> resolved |
| 2016-09-24 03:35:33 | python-dev | set | nosy: + python-devmessages: + |
| 2016-09-21 09:01:31 | christian.heimes | set | assignee: christian.heimes -> messages: + |
| 2016-09-21 04:12:24 | martin.panter | set | messages: + stage: needs patch |
| 2016-09-21 01:35:05 | martin.panter | create |