Issue 28256: Cleanup Modules/_math.c - Python tracker (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/72443

classification

Title:	Cleanup Modules/_math.c
Type:	Stage:
Components:	Versions:	Python 3.7

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	christian.heimes, mark.dickinson, python-dev, serhiy.storchaka, vstinner
Priority:	normal	Keywords:	patch

Created on 2016-09-23 09:59 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
math.patch	vstinner,2016-09-23 09:59	review

Messages (4)
msg277266 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-09-23 09:59
On a code coverage report, I noticed that _math.c has a very bad coverage. In fact, we define dead code when the system provides most required math functions. Attached patch avoids declaring unused functions. See the coverage at: http://tiran.bitbucket.org/python-lcov/Modules/index.html
msg277276 - (view)	Author: Christian Heimes (christian.heimes) *	Date: 2016-09-23 13:21
It think you have the #ifdef checks reversed, e.g. #ifdef HAVE_ACOSH instead of #ifndef HAVE_ACOSH.
msg278883 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-10-18 14:32
New changeset 8999d702ac29 by Victor Stinner in branch 'default': Issue #28256: Cleanup _math.c https://hg.python.org/cpython/rev/8999d702ac29
msg278884 - (view)	Author: STINNER Victor (vstinner) *	Date: 2016-10-18 14:33
Thanks for the review Serhiy and Christian, it seems like a review was needed :-D I pushed my fix to Python 3.7.

History
Date	User	Action	Args
2022-04-11 14:58:37	admin	set	github: 72443
2016-10-18 14:33:01	vstinner	set	status: open -> closedresolution: fixedmessages: +
2016-10-18 14:32:07	python-dev	set	nosy: + python-devmessages: +
2016-09-23 14:24:12	serhiy.storchaka	set	nosy: + serhiy.storchaka
2016-09-23 13:21:40	christian.heimes	set	messages: +
2016-09-23 09:59:22	vstinner	create