Issue 28269: [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp (original) (raw)

Issue28269

Created on 2016-09-25 10:48 by vmurashev, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg277362 - (view)	Author: Vitaly Murashev (vmurashev) *	Date: 2016-09-25 10:48
Attempt to complile Python/dynload_win.c by MinGW fails due to static reimplementation of strcasecmp function in this file: --- /* Case insensitive string compare, to avoid any dependencies on particular C RTL implementations */ static int strcasecmp (char *string1, char *string2) { int first, second; do { first = tolower(*string1); second = tolower(*string2); string1++; string2++; } while (first && first == second); return (first - second); } --- And this reimplementation clashed with native declaration of strcasecmp() which one is a part of MinGW runtime So suggested patch (for 3.5.2 and 2.7.12) just disables static reimplementation of strcasecmp for MinGW
msg277761 - (view)	Author: Steve Dower (steve.dower) *	Date: 2016-09-30 16:37
Why not replace it entirely with stricmp? Does it behave differently?
msg347812 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2019-07-13 13:11
New changeset 05f2d84cae4ba1ff15b7a1d0347305393f4bdcc5 by Serhiy Storchaka (Minmin Gong) in branch 'master': bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095) https://github.com/python/cpython/commit/05f2d84cae4ba1ff15b7a1d0347305393f4bdcc5
msg350362 - (view)	Author: miss-islington (miss-islington)	Date: 2019-08-24 10:22
New changeset 920ec4b7763d64b3742d7ddd339ad11cdbec62e9 by Miss Islington (bot) in branch '3.8': bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095) https://github.com/python/cpython/commit/920ec4b7763d64b3742d7ddd339ad11cdbec62e9
msg350363 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2019-08-24 10:31
Thank you for your PR Minmin. It was decided to not backport it to 3.7.