Issue 28395: Remove unnecessary semicolons in tests (original) (raw)
Created on 2016-10-09 11:49 by nnnnnn, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| semicolons.patch | nnnnnn,2016-10-09 11:49 | review |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26868 | merged | corona10,2021-06-23 06:15 | |
| PR 26870 | merged | miss-islington,2021-06-23 09:01 | |
| PR 26871 | merged | miss-islington,2021-06-23 09:01 |
| Messages (5) | ||
|---|---|---|
| msg278404 - (view) | Author: Mariatta (Mariatta) *  |
Date: 2016-10-10 06:49 |
| Thanks scop. The patch looks good to me, and it can be applied cleanly to 3.5, 3.6, and default branches. I did find more occurrences of unnecessary semicolons, for example (not a complete list) https://github.com/python/cpython/blob/master/Lib/smtpd.py#L569 https://github.com/python/cpython/blob/master/Lib/smtpd.py#L611 https://github.com/python/cpython/blob/master/Lib/test/test_itertools.py#L120 https://github.com/python/cpython/blob/master/Lib/test/test_pyexpat.py#L572 Not sure if it's really worth trying to fix all of them? Thanks :) | ||
| msg396364 - (view) | Author: Irit Katriel (iritkatriel) * |
Date: 2021-06-22 21:25 |
| The patch needs to be converted to a github PR. | ||
| msg396392 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2021-06-23 09:01 |
| New changeset 5a3108044d2e5b694da2d1f4176c9bbaef15c142 by Dong-hee Na in branch 'main': bpo-28395: Remove unnecessary semicolons in tests (GH-26868) https://github.com/python/cpython/commit/5a3108044d2e5b694da2d1f4176c9bbaef15c142 | ||
| msg396400 - (view) | Author: miss-islington (miss-islington) | Date: 2021-06-23 10:02 |
| New changeset 280425d41797f9c0b20fb02a22341937a13a8987 by Miss Islington (bot) in branch '3.10': bpo-28395: Remove unnecessary semicolons in tests (GH-26868) https://github.com/python/cpython/commit/280425d41797f9c0b20fb02a22341937a13a8987 | ||
| msg396401 - (view) | Author: miss-islington (miss-islington) | Date: 2021-06-23 10:03 |
| New changeset fcde2c6a8c99a56576b25733d5cc60bce6d51f46 by Miss Islington (bot) in branch '3.9': bpo-28395: Remove unnecessary semicolons in tests (GH-26868) https://github.com/python/cpython/commit/fcde2c6a8c99a56576b25733d5cc60bce6d51f46 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:38 | admin | set | github: 72581 |
| 2021-06-23 10:03:16 | corona10 | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2021-06-23 10:03:03 | miss-islington | set | messages: + |
| 2021-06-23 10:02:44 | miss-islington | set | messages: + |
| 2021-06-23 09:01:32 | miss-islington | set | pull_requests: + <pull%5Frequest25446> |
| 2021-06-23 09:01:26 | miss-islington | set | nosy: + miss-islingtonpull_requests: + <pull%5Frequest25445> |
| 2021-06-23 09:01:10 | corona10 | set | messages: + |
| 2021-06-23 06:15:19 | corona10 | set | nosy: + corona10pull_requests: + <pull%5Frequest25443>stage: patch review |
| 2021-06-22 21:25:38 | iritkatriel | set | nosy: + iritkatrielversions: + Python 3.9, Python 3.10, Python 3.11messages: + keywords: + easytitle: Remove unnecessary semicolons -> Remove unnecessary semicolons in tests |
| 2016-10-10 06:49:37 | Mariatta | set | nosy: + Mariattamessages: + |
| 2016-10-09 11:49:02 | nnnnnn | create |