| msg66828 - (view) |
Author: Brett Cannon (brett.cannon) *  |
Date: 2008-05-14 20:09 |
| gestalt was removed as part of the stdlib cleanup for Mac code. But it turns out that gestalt is one of those modules that is just needed. Either the original version needs to be added back in or a ctypes version needs to be implemented. Either way, something to get system info needs to be added back into the stdlib (and probably go into plat-darwin). |
|
|
| msg66831 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2008-05-14 20:27 |
| Actually, the plat-darwin comment is not right if the original C version is kept since that would just end up in Modules. |
|
|
| msg66832 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-14 20:37 |
| Does it have to be public? How about _gestalt? |
|
|
| msg66836 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2008-05-14 23:10 |
| On Wed, May 14, 2008 at 1:37 PM, Benjamin Peterson <report@bugs.python.org> wrote: > > Benjamin Peterson <musiccomposition@gmail.com> added the comment: > > Does it have to be public? How about _gestalt? > That's fine by me. If someone really cares enough they can document it themselves. |
|
|
| msg66837 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-15 01:01 |
| I feel kinda bad about removing the module without noting how it was used in platform.py, so I'll deal with this. |
|
|
| msg66838 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2008-05-15 01:02 |
| On Wed, May 14, 2008 at 6:01 PM, Benjamin Peterson <report@bugs.python.org> wrote: > > Benjamin Peterson <musiccomposition@gmail.com> added the comment: > > I feel kinda bad about removing the module without noting how it was > used in platform.py, so I'll deal with this. > While I am not going to stop you dealing with it, you shouldn't feel bad. It would have been best had a test case in test_platform picked this up (if you can it would be great to toss a test in). |
|
|
| msg66878 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-15 21:32 |
| Here's a patch. I moved gestalt to Modules and renamed it _gestalt. I inlined the few lines of pymactoolbox that I needed, so that doesn't have to come back. |
|
|
| msg67076 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-19 21:03 |
| This is just a reminder to myself that when this is checked in, I need to unblock and merge r63460 and r63464. |
|
|
| msg67512 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-29 21:25 |
| _gestalt was added in 63795. |
|
|