| msg279940 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 20:06 |
| Some valid JPEG images are not detected by the imghdr lib. |
|
|
| msg279941 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 20:10 |
| Other valid jpeg image not detected. |
|
|
| msg279946 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 21:02 |
| patch for python 2.7 |
|
|
| msg279947 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 21:03 |
| patch for python 3.X |
|
|
| msg279948 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 21:05 |
| patch for python 3.X |
|
|
| msg279949 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 21:07 |
| Working imghdr lib for python 2.7.X |
|
|
| msg279950 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-02 21:08 |
| Working imghdr lib for python 3.X |
|
|
| msg279952 - (view) |
Author: R. David Murray (r.david.murray) *  |
Date: 2016-11-02 21:40 |
| There seem to be unrelated changes in your patches, and we'll want tests as well before committing. See also issue 16512 and the issues linked from it. (I haven't reviewed to see if there is any overlap.) |
|
|
| msg279963 - (view) |
Author: Kovid Goyal (kovid) |
Date: 2016-11-03 04:06 |
| FYI, the uptodate version of imghdr I maintain is here: https://github.com/kovidgoyal/calibre/blob/master/src/calibre/utils/imghdr.py It uses memoryview for performance and can also also read image sizes from file headers for jpeg, png, gif and jpeg2000. Note that is is only tested on python 2.7 I'm afraid I dont have the time to shepherd it through your review process, but feel free to take code from it if you want to. It is licensed GPLv3 but I am willing to re-license to another license if needed, as I am the sole contributor. |
|
|
| msg279965 - (view) |
Author: Xiang Zhang (xiang.zhang) * |
Date: 2016-11-03 05:02 |
| There is also #27121 reporting similar problem. |
|
|
| msg280544 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-10 21:32 |
| New patch for imghdr bug, including unittets. This patch works on python 3.x |
|
|
| msg280545 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-10 21:35 |
| Image used in the unit-tests of previous patch. Add it under Lib/test/imghdrdata/python1.jpg |
|
|
| msg280546 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-10 21:37 |
| The don't solve the problem, note how the patch it provide fails to detect all the valid JPEG images attached in this issue. |
|
|
| msg280550 - (view) |
Author: Raul (4simple-org) |
Date: 2016-11-10 23:13 |
| New patch for imghdr bug, including unittets. This patch works on python 2.7 |
|
|
| msg415044 - (view) |
Author: Irit Katriel (iritkatriel) * |
Date: 2022-03-13 17:12 |
| imghdr is deprecated as per PEP 594, so there won't be further enhancements to it. |
|
|
