Issue 28644: Document recent changes in typing.py (original) (raw)

Created on 2016-11-09 00:38 by levkivskyi, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
recent-typing-docs.diff levkivskyi,2016-11-09 00:38 review
recent-typing-docs-v2.diff levkivskyi,2016-11-09 00:47 review
recent-typing-docs-v3.diff levkivskyi,2016-11-09 09:00 review
recent-typing-docs-v4.diff levkivskyi,2016-11-10 14:00 review
recent-typing-docs-v5.diff levkivskyi,2016-11-11 15:02 review
recent-typing-docs-v6.diff levkivskyi,2016-11-11 15:03 review
Messages (7)
msg280364 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 00:38
Here is the patch with recent additions/changes in typing.py Summary: Tuple and Callable are now classes, generic type aliases, added Coroutine, extended docs for get_type_hints.
msg280366 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 00:47
Sorry, here is the patch with corrected formatting and base classes for Coroutine.
msg280373 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2016-11-09 03:19
Hi Ivan, I noticed you used two space indentation in your docs patch. Can you use 3 spaces instead? More guidelines here: https://docs.python.org/devguide/documenting.html?#use-of-whitespace Thanks :)
msg280381 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 09:00
Thanks Mariatta, here is a new version of patch with indentation fixed.
msg280506 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-10 14:00
Guido, here is a new patch with your comments implemented.
msg280587 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-11 15:02
Guido, here is the new patch with your corrections. I have some questions in Rietveld, but those are about mypy, you could apply the patch now.
msg280623 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-11-11 23:58
New changeset 5bf2ea0d3830 by Guido van Rossum in branch '3.5': Issue 28644: Document recent changes in typing.py (Ivan L) https://hg.python.org/cpython/rev/5bf2ea0d3830 New changeset 72a2c90abdec by Guido van Rossum in branch '3.6': Issue 28644: Document recent changes in typing.py (Ivan L) (3.5->3.6) https://hg.python.org/cpython/rev/72a2c90abdec New changeset c4394da344b7 by Guido van Rossum in branch 'default': Issue 28644: Document recent changes in typing.py (Ivan L) (3.6->3.7) https://hg.python.org/cpython/rev/c4394da344b7
History
Date User Action Args
2022-04-11 14:58:39 admin set github: 72830
2016-11-11 23:59:06 gvanrossum set status: open -> closedresolution: fixedstage: resolved
2016-11-11 23:58:39 python-dev set nosy: + python-devmessages: +
2016-11-11 15:03:49 levkivskyi set files: + recent-typing-docs-v6.diff
2016-11-11 15:02:04 levkivskyi set files: + recent-typing-docs-v5.diffmessages: +
2016-11-10 20:46:49 gvanrossum set title: Document recen changes in typing.py -> Document recent changes in typing.py
2016-11-10 14:00:15 levkivskyi set files: + recent-typing-docs-v4.diffmessages: +
2016-11-09 09:00:43 levkivskyi set files: + recent-typing-docs-v3.diffmessages: +
2016-11-09 03:19:19 Mariatta set nosy: + Mariattamessages: +
2016-11-09 00:47:23 levkivskyi set files: + recent-typing-docs-v2.diffmessages: +
2016-11-09 00:38:11 levkivskyi create