Issue 28667: FD_SETSIZE is unsigned on FreeBSD (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/72853
classification
Title: | FD_SETSIZE is unsigned on FreeBSD | ||
---|---|---|---|
Type: | compile error | Stage: | resolved |
Components: | FreeBSD | Versions: | Python 3.7, Python 3.6 |
process
Status: | closed | Resolution: | fixed |
---|---|---|---|
Dependencies: | Superseder: | ||
Assigned To: | serhiy.storchaka | Nosy List: | koobs, serhiy.storchaka, skrah, vstinner |
Priority: | normal | Keywords: | patch |
Created on 2016-11-11 14:03 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
Files | |||
---|---|---|---|
File name | Uploaded | Description | Edit |
FD_SETSIZE.patch | serhiy.storchaka,2016-11-11 14:03 | review |
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 501 | closed | serhiy.storchaka,2017-03-06 08:33 | |
PR 3190 | merged | vstinner,2017-08-22 16:35 |
Messages (3) | ||
---|---|---|
msg280581 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * ![]() |
Date: 2016-11-11 14:03 |
Seems FreeBSD is the only platforms with unsigned FD_SETSIZE. On NetBSD, Linux, and OpenBSD it is defined as just int. [1] This causes compiler warnings on FreeBSD. [2] Modules/selectmodule.c:72: warning: comparison between signed and unsigned Modules/selectmodule.c:112: warning: comparison between signed and unsigned Modules/selectmodule.c:123: warning: comparison between signed and unsigned Modules/ossaudiodev.c:476: warning: comparison between signed and unsigned Proposed patch silences warnings. [1] https://lists.freebsd.org/pipermail/freebsd-standards/2012-July/002410.html [2] http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/5310/steps/compile/logs/warnings%20%2817%29 | ||
msg290197 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * ![]() |
Date: 2017-03-24 22:22 |
New changeset 783d0c1a1c723733adcdf4249240246fc35a5bcb by Serhiy Storchaka in branch 'master': bpo-28667: Fix a compile warning on FreeBSD when compare with FD_SETSIZE. (#501) https://github.com/python/cpython/commit/783d0c1a1c723733adcdf4249240246fc35a5bcb | ||
msg300729 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2017-08-22 22:58 |
New changeset cb7fdf69ec9235cb358580f189089eaf575fb9df by Victor Stinner in branch '3.6': bpo-28667: Fix a compile warning on FreeBSD when compare with FD_SETSIZE. (#501) (#3190) https://github.com/python/cpython/commit/cb7fdf69ec9235cb358580f189089eaf575fb9df |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:58:39 | admin | set | github: 72853 |
2017-08-22 22:58:49 | vstinner | set | nosy: + vstinnermessages: + |
2017-08-22 16:35:28 | vstinner | set | pull_requests: + <pull%5Frequest3229> |
2017-03-24 22:22:11 | serhiy.storchaka | set | messages: + |
2017-03-12 12:51:30 | serhiy.storchaka | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
2017-03-06 08:33:55 | serhiy.storchaka | set | pull_requests: + <pull%5Frequest409> |
2016-11-20 14:48:41 | serhiy.storchaka | set | assignee: serhiy.storchaka |
2016-11-11 14:03:10 | serhiy.storchaka | create |