Issue 28979: What's New entry on compact dict mentions "faster" implementation (original) (raw)

Issue28979

Created on 2016-12-15 13:52 by Jim Fasarakis-Hilliard, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
whatsnew36.patch brendan-donegan,2016-12-15 15:09 review
Messages (6)
msg283304 - (view) Author: Jim Fasarakis-Hilliard (Jim Fasarakis-Hilliard) * Date: 2016-12-15 13:52
Specifically, the entry reads: "The dict type has been reimplemented to use a faster, more compact representation similar to the PyPy dict implementation." Through, the text describing the new implementation doesn't mention anything on speed, it only mentions memory usage. and, specifically, even report a slight regression ok key look-ups. Am I interpreting this differently? If not, is it a good idea to be stating it is faster?
msg283319 - (view) Author: Brendan Donegan (brendan-donegan) * Date: 2016-12-15 15:09
Agree. Patch provided.
msg283323 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-15 15:22
New changeset 181453f9a0c4 by Victor Stinner in branch '3.6': Issue #28979: Fix What's New in Python 3.6, dict https://hg.python.org/cpython/rev/181453f9a0c4
msg283325 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-15 15:23
@Ned: Would you be ok to cherry-pick 181453f9a0c4 in Python 3.6.0?
msg283372 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-16 07:44
New changeset 911cc601089d by Victor Stinner in branch '3.6': Issue #28979: Fix What's New in Python 3.6, dict https://hg.python.org/cpython/rev/911cc601089d
msg283385 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-12-16 07:55
[cherrypicked for 3.6.0rc2]
History
Date User Action Args
2022-04-11 14:58:40 admin set github: 73165
2016-12-16 07:55:29 ned.deily set status: open -> closedpriority: release blocker -> messages: + resolution: fixedstage: resolved
2016-12-16 07:44:42 python-dev set messages: +
2016-12-15 15:54:42 ned.deily set priority: normal -> release blocker
2016-12-15 15:23:46 vstinner set nosy: + ned.deily, methane, serhiy.storchaka, yselivanov
2016-12-15 15:23:26 vstinner set nosy: + vstinnermessages: +
2016-12-15 15:22:27 python-dev set nosy: + python-devmessages: +
2016-12-15 15:09:27 brendan-donegan set files: + whatsnew36.patchnosy: + brendan-doneganmessages: + keywords: + patch
2016-12-15 13:52:12 Jim Fasarakis-Hilliard create