Issue 29009: Outdated part in the doc of PyUnicode_RichCompare (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/73195
classification
| Title: | Outdated part in the doc of PyUnicode_RichCompare | ||
|---|---|---|---|
| Type: | Stage: | resolved | |
| Components: | Documentation | Versions: | Python 3.7, Python 3.6, Python 3.5 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | xiang.zhang | Nosy List: | docs@python, python-dev, serhiy.storchaka, vstinner, xiang.zhang |
| Priority: | normal | Keywords: | patch |
Created on 2016-12-19 04:30 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| doc-of-PyUnicode_RichCompare.patch | xiang.zhang,2016-12-19 04:30 | review | |
| doc-of-PyUnicode_RichCompare_v2.patch | xiang.zhang,2016-12-19 06:08 | review |
| Messages (6) | ||
|---|---|---|
| msg283578 - (view) | Author: Xiang Zhang (xiang.zhang) *  |
Date: 2016-12-19 04:30 |
| The sentence: "Note that Py_EQ and Py_NE comparisons can cause a UnicodeWarning in case the conversion of the arguments to Unicode fails with a UnicodeDecodeError." in the doc of PyUnicode_RichCompare is not true in 3.x. Proposed patch simply deletes it. | ||
| msg283585 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-12-19 05:43 |
| This sentence also is in the header. | ||
| msg283587 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2016-12-19 06:08 |
| > This sentence also is in the header. Ohh, yes. Thanks Serhiy! | ||
| msg283589 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-12-19 06:10 |
| LGTM. | ||
| msg283600 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2016-12-19 10:08 |
| doc-of-PyUnicode_RichCompare_v2.patch LGTM. | ||
| msg283605 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-12-19 10:43 |
| New changeset 8f5ed2a38f64 by Xiang Zhang in branch '3.5': Issue #29009: Remove outdated doc of PyUnicode_RichCompare. https://hg.python.org/cpython/rev/8f5ed2a38f64 New changeset da958d01755a by Xiang Zhang in branch '3.6': Issue #29009: Merge 3.5. https://hg.python.org/cpython/rev/da958d01755a New changeset 9568343fde42 by Xiang Zhang in branch 'default': Issue #29009: Merge 3.6. https://hg.python.org/cpython/rev/9568343fde42 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:40 | admin | set | github: 73195 |
| 2016-12-19 10:44:42 | xiang.zhang | set | status: open -> closedresolution: fixedstage: commit review -> resolved |
| 2016-12-19 10:43:42 | python-dev | set | nosy: + python-devmessages: + |
| 2016-12-19 10:08:12 | vstinner | set | messages: + |
| 2016-12-19 06:10:37 | serhiy.storchaka | set | assignee: docs@python -> xiang.zhangmessages: + stage: patch review -> commit review |
| 2016-12-19 06:08:55 | xiang.zhang | set | files: + doc-of-PyUnicode_RichCompare_v2.patchmessages: + |
| 2016-12-19 05:43:13 | serhiy.storchaka | set | nosy: + serhiy.storchakamessages: + |
| 2016-12-19 04:30:59 | xiang.zhang | create |