original ) (raw ) Issue29648
Created on 2017-02-25 11:22 by marco.buttu , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Pull Requests
URL
Status
Linked
Edit
PR 277 Mariatta,2017-02-25 11:24
PR 290 merged
marco.buttu,2017-02-25 11:56
PR 314 merged
Mariatta,2017-02-26 15:23
PR 315 merged
Mariatta,2017-02-26 15:24
Messages (7)
msg288560 - (view) Author: Marco Buttu (marco.buttu) *
Date: 2017-02-25 11:22
In the first `versionadded` of the Loader section [1] of Doc/reference/import.rst , there is no reference to `create_module()`: .. versionadded:: 3.4 The create_module() method of loaders. It should be: .. versionadded:: 3.4 The :meth:`~importlib.abc.Loader.create_module` method of loaders. I will make a PR. [1] https://docs.python.org/3/reference/import.html#loaders
msg288572 - (view) Author: Mariatta (Mariatta) *
Date: 2017-02-25 16:58
Thanks, Marco. Your change looks good to me. I'm now wondering if this should have been 'versionchanged' instead of 'versionadded'. Perhaps other core devs can confirm this. Thanks :)
msg288596 - (view) Author: Alyssa Coghlan (ncoghlan) *
Date: 2017-02-26 14:20
Version added is correct here, as the "create_module()" methods are all new in 3.4, and the traditional granularity for deciding "addition or change?" is that new functions, methods, and attributes are always additions, even if they're being added to a class definition.
msg288597 - (view) Author: Mariatta (Mariatta) *
Date: 2017-02-26 15:41
Thanks for the clarification, Nick :) Marco, I merged your PR, and backported to 3.5 and 3.6 branches. Thanks!
msg290385 - (view) Author: Mariatta (Mariatta) *
Date: 2017-03-24 23:41
New changeset 63ed9bc94d8df45b16aee9b92f658ebb34aa1012 by Mariatta in branch '3.5': bpo-29648 : import.rst: Add reference to create_module() (GH-290 ) (GH-315 ) https://github.com/python/cpython/commit/63ed9bc94d8df45b16aee9b92f658ebb34aa1012
msg290387 - (view) Author: Mariatta (Mariatta) *
Date: 2017-03-24 23:41
New changeset 7333d1760e12cf27bcf63265f72521892285c10a by Mariatta in branch '3.6': bpo-29648 : import.rst: Add reference to create_module() (GH-290 ) (GH-314 ) https://github.com/python/cpython/commit/7333d1760e12cf27bcf63265f72521892285c10a
msg290392 - (view) Author: Mariatta (Mariatta) *
Date: 2017-03-24 23:42
New changeset 46ce7599af82a929506baeaaee5c149970440c4c by Mariatta (Marco Buttu) in branch 'master': bpo-29648 : import.rst: Add reference to create_module() (GH-290 ) https://github.com/python/cpython/commit/46ce7599af82a929506baeaaee5c149970440c4c
History
Date
User
Action
Args
2022-04-11 14:58:43
admin
set
github: 73834
2017-03-24 23:42:22
Mariatta
set
messages: +
2017-03-24 23:41:42
Mariatta
set
messages: +
2017-03-24 23:41:21
Mariatta
set
messages: +
2017-02-26 15:41:55
Mariatta
set
status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2017-02-26 15:24:33
Mariatta
set
pull_requests: + <pull%5Frequest276>
2017-02-26 15:23:46
Mariatta
set
pull_requests: + <pull%5Frequest275>
2017-02-26 14:20:41
ncoghlan
set
messages: +
2017-02-26 07:31:42
serhiy.storchaka
set
nosy: + brett.cannon , ncoghlan , eric.snow
2017-02-25 16:58:34
Mariatta
set
nosy: + Mariatta , docs@python messages: + assignee: docs@python components: + Documentationstage: patch review
2017-02-25 11:56:18
marco.buttu
set
pull_requests: + <pull%5Frequest261>
2017-02-25 11:24:48
Mariatta
set
pull_requests: + <pull%5Frequest260>
2017-02-25 11:22:08
marco.buttu
create
