Issue 29682: Possible missing NULL check in pyexpat (original) (raw)

Hi,

Our tool reported a position that doesn't check for returned value (from a function that might returns null). might need a look that is there any problem or I am missing something.

in function PyUnknownEncodingHandler of file pyexpat.c,

if (namespace_separator != NULL) {
    self->itself = XML_ParserCreateNS(encoding, *namespace_separator);
}
else {
    self->itself = XML_ParserCreate(encoding);           // could XML_ParserCreate returns null in this point?
}

..... XML_SetHashSalt(self->itself, // if it does return null, null pointer will passed into XML_SetHashSalt and will be dereferenced. (unsigned long)_Py_HashSecret.prefix);
#endif