Issue 29726: test_xmlrpc raises DeprecationWarnings (original) (raw)

Issue29726

Created on 2017-03-05 17:15 by dillon.brock, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg289026 - (view)	Author: Dillon Brock (dillon.brock) *	Date: 2017-03-05 17:15
In 3 unit tests, test_xmlrpc calls assertRaises(Exception, expectedRegex='method'), causing DeprecationWarnings. These calls should be replaced with assertRaisesRegex(Exception, 'method'). 0:20:56 [378/404] test_xmlrpc 127.0.0.1 - - [05/Mar/2017 11:53:45] "POST / HTTP/1.1" 200 - 127.0.0.1 - - [05/Mar/2017 11:53:45] "POST / HTTP/1.1" 200 - /home/dillon/src/cpython/Lib/test/test_xmlrpc.py:430: DeprecationWarning: 'expected_regex' is an invalid keyword argument for this function with self.assertRaises(Exception, expected_regex='method'): /home/dillon/src/cpython/Lib/test/test_xmlrpc.py:423: DeprecationWarning: 'expected_regex' is an invalid keyword argument for this function with self.assertRaises(Exception, expected_regex='method'): /home/dillon/src/cpython/Lib/test/test_xmlrpc.py:415: DeprecationWarning: 'expected_regex' is an invalid keyword argument for this function with self.assertRaises(Exception, expected_regex='method'):
msg289027 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2017-03-05 17:29
Thank you Dillon! Could you backport your changes to 3.6 and 3.5?
msg289050 - (view)	Author: Dillon Brock (dillon.brock) *	Date: 2017-03-05 23:22
The cherry-pick is causing a merge conflict because 3.6 and 3.5 do not include the SimpleXMLRPCDispatcherTestCase that this fix modifies. Should I backport that entire test case as well as the fix?
msg289667 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2017-03-15 11:14
Thanks, Dillon! I went ahead and backported PR 481 to 3.5 and 3.6 branches.