Issue 29774: Improve zipfile handling of corrupted extra field (original) (raw)
Issue29774
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/73960
classification
| Title: | Improve zipfile handling of corrupted extra field | ||
|---|---|---|---|
| Type: | enhancement | Stage: | resolved |
| Components: | Library (Lib) | Versions: | Python 3.7 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | Nosy List: | serhiy.storchaka, vstinner | |
| Priority: | normal | Keywords: |
Created on 2017-03-09 15:27 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 583 | merged | serhiy.storchaka,2017-03-09 15:33 |
| Messages (4) | ||
|---|---|---|
| msg289302 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2017-03-09 15:27 |
| The zipfile module can raise struct.error when process corrupted extra field. This issue was partially resolved by . Following PR converts struct.error to BadZipFile in other case. | ||
| msg289307 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-03-09 16:51 |
| I merged your PR, thanks! I don't think that this minor enhancement on error message is worth it to be backported. It only impacts corrupted ZIP files, and 3.6 and older already raise an error message. I updated manually the PR status, it seems like the GitHub bot is still broken. | ||
| msg289311 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-03-09 17:21 |
| I think the same. | ||
| msg290249 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-03-24 22:38 |
| New changeset feccdb2a249a71be330765be77dee57121866779 by Victor Stinner (Serhiy Storchaka) in branch 'master': bpo-29774: Improve error reporting for corrupted extra field in ZIP file. (#583) https://github.com/python/cpython/commit/feccdb2a249a71be330765be77dee57121866779 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:44 | admin | set | github: 73960 |
| 2017-03-24 22:38:20 | vstinner | set | messages: + |
| 2017-03-09 17:21:44 | serhiy.storchaka | set | messages: + |
| 2017-03-09 16:51:08 | vstinner | set | nosy: + vstinnermessages: + |
| 2017-03-09 16:48:24 | serhiy.storchaka | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2017-03-09 15:33:55 | serhiy.storchaka | set | pull_requests: + <pull%5Frequest480> |
| 2017-03-09 15:28:25 | serhiy.storchaka | set | type: behavior -> enhancementversions: - Python 2.7, Python 3.5, Python 3.6 |
| 2017-03-09 15:27:35 | serhiy.storchaka | create |
Supported by The Python Software Foundation,
Powered by Roundup
Copyright © 1990-2022, Python Software Foundation
Legal Statements