Issue 29873: Need a look for return value checking [_elementtree.c] (original) (raw)

In file _elementtree.c

our static code scanner has reported this case, but I don't sure that could be any problem, may you have a look?

static PyObject*
element_getattr(ElementObject* self, char* name) { PyObject* res;

/* handle common attributes first */
if (strcmp(name, "tag") == 0) {
    res = self->tag;
    Py_INCREF(res);
    return res;
} else if (strcmp(name, "text") == 0) {
    res = element_get_text(self);         // is it possible that element_get_text could return NULL here?
    Py_INCREF(res);
    return res;
}