Issue 29920: Document cgitb.text and cgitb.html (original) (raw)

Created on 2017-03-27 13:16 by xmorel, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 849 merged xmorel,2017-03-27 13:57
PR 1527 closed berker.peksag,2017-05-10 08:50
PR 1528 closed berker.peksag,2017-05-10 08:52
Messages (8)
msg290608 - (view) Author: Xavier Morel (xmorel) * Date: 2017-03-27 13:16
Currently, cgitb documents the hook (enable) and somewhat unclearly the ability to dump the HTML traceback to stdout, but despite that being technically available it does not document the ability to dump the traceback to a string as either text or html. Possible further improvement: make ``cgitb.html`` and ``cgitb.text`` implicitly call `sys.exc_info()` if not given a parameter (much like `cgitb.handler` does).
msg290612 - (view) Author: Xavier Morel (xmorel) * Date: 2017-03-27 13:57
PR targetted to master rather than 2.7
msg293072 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-05-05 08:15
New changeset c07b3a15be5e0a68a73b4c532861ed8de6932bd2 by Berker Peksag (masklinn) in branch 'master': bpo-29920: Document cgitb.text() and cgitb.html() functions (GH-849) https://github.com/python/cpython/commit/c07b3a15be5e0a68a73b4c532861ed8de6932bd2
msg293394 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-05-10 09:24
The main functions of the cgitb module are enable() and handler(). I would describe them first, and text() and html() at the end (maybe in separate subsection). Actually the main part of the descriptions of text() and html() can be shared and placed in a paragraph preceding them: "The following two functions handle..." Note that the documented name of the first parameter is "info", but actual name is "einfo".
msg294926 - (view) Author: Xavier Morel (xmorel) * Date: 2017-06-01 09:51
Should I close this since the PR was merged?
msg294929 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-01 10:25
I suggest to move the descriptions of text() and html() after handle(). And I don't know what to do with the discrepancy in the parameter name.
msg294949 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-06-01 14:48
Please don't close it yet. I agree with Serhiy's comments in , but I couldn't find time to address his comments yet (plus we still need to backport the documentation update to 3.5 and 3.6 branches)
msg416578 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2022-04-02 18:57
Closing as the backport to 3.5/3.6 is no longer relevant and also cgitb is deprecated under 594.
History
Date User Action Args
2022-04-11 14:58:44 admin set github: 74106
2022-04-02 18:57:18 iritkatriel set status: open -> closednosy: + iritkatrielmessages: + resolution: fixedstage: resolved
2017-06-01 14:48:14 berker.peksag set messages: +
2017-06-01 10:25:03 serhiy.storchaka set messages: + versions: - Python 2.7, Python 3.5, Python 3.6
2017-06-01 09:51:31 xmorel set messages: +
2017-05-10 09:24:52 serhiy.storchaka set nosy: + serhiy.storchaka, martin.pantermessages: +
2017-05-10 08:52:34 berker.peksag set pull_requests: + <pull%5Frequest1627>
2017-05-10 08:50:47 berker.peksag set pull_requests: + <pull%5Frequest1626>
2017-05-05 08:15:14 berker.peksag set nosy: + berker.peksagmessages: +
2017-03-27 13:57:49 xmorel set pull_requests: - <pull%5Frequest747>
2017-03-27 13:57:38 xmorel set messages: + pull_requests: + <pull%5Frequest748>
2017-03-27 13:49:48 Mariatta set versions: + Python 3.5
2017-03-27 13:16:48 xmorel create