original ) (raw ) Issue29927
Created on 2017-03-28 02:23 by cocoatomo , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Pull Requests
URL
Status
Linked
Edit
PR 866 merged
louielu,2017-03-28 06:45
Messages (4)
msg290678 - (view) Author: Tomohiko Kinebuchi (cocoatomo) *
Date: 2017-03-28 02:23
1. BufferError is PRE_INIT'ed twice, and also POST_INIT'ed twice. 2. Using macros (PRE_INIT, POST_INIT and ADD_ERRNO) with following unnecessary semicolons. These unnecessary code have no semantic effect, but is somehow confusing.
msg290685 - (view) Author: Louie Lu (louielu) *
Date: 2017-03-28 06:37
It seems somehow the patch at #3295 make the mistake, commit faa54a39295 at 2007-08-19 add the PRE_INIT(BufferError) and POST_INIT(BufferError), but in #3295 `buffererror.patch` didn't saw it.
msg290769 - (view) Author: Xiang Zhang (xiang.zhang) *
Date: 2017-03-29 05:28
New changeset c431854a0963d4ec2875efab2d2425a738895280 by Xiang Zhang (Louie Lu) in branch 'master': bpo-29927 : Remove duplicate BufferError init and unnecessary semicolons (GH-866 ) https://github.com/python/cpython/commit/c431854a0963d4ec2875efab2d2425a738895280
msg290770 - (view) Author: Xiang Zhang (xiang.zhang) *
Date: 2017-03-29 05:29
Since the unnecessary codes have no semantic effect, I think they only need to go in 3.7. Thanks for your report and patch!
History
Date
User
Action
Args
2022-04-11 14:58:44
admin
set
github: 74113
2017-03-29 05:31:34
xiang.zhang
set
versions: - Python 3.5, Python 3.6
2017-03-29 05:31:10
xiang.zhang
set
status: open -> closed
2017-03-29 05:29:51
xiang.zhang
set
resolution: fixedmessages: + stage: resolved
2017-03-29 05:28:18
xiang.zhang
set
nosy: + xiang.zhang messages: +
2017-03-28 06:45:13
louielu
set
pull_requests: + <pull%5Frequest767>
2017-03-28 06:37:53
louielu
set
nosy: + louielu messages: +
2017-03-28 02:23:00
cocoatomo
create
