Issue 29932: Missing word ("be") in error message ("first argument must a type object") (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/74118
classification
Title: | Missing word ("be") in error message ("first argument must a type object") | ||
---|---|---|---|
Type: | enhancement | Stage: | resolved |
Components: | Versions: | Python 3.7 |
process
Status: | closed | Resolution: | fixed |
---|---|---|---|
Dependencies: | Superseder: | ||
Assigned To: | Nosy List: | Jim Fasarakis-Hilliard, SylvainDe, brett.cannon | |
Priority: | normal | Keywords: |
Created on 2017-03-28 12:35 by SylvainDe, last changed 2022-04-11 14:58 by admin. This issue is now closed.
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 888 | merged | SylvainDe,2017-03-29 17:02 |
Messages (4) | ||
---|---|---|
msg290701 - (view) | Author: SylvainDe (SylvainDe) * | Date: 2017-03-28 12:35 |
Very uninteresting issue but error message should probably be "first argument must BE a type object" in `array__array_reconstructor_impl` in Modules/arraymodule.c . This has been introduced with ad077154d0f305ee0ba5bf41d3cb47d1d9c43e7b . I'll handle this issue in the next day. | ||
msg290710 - (view) | Author: Jim Fasarakis-Hilliard (Jim Fasarakis-Hilliard) * | Date: 2017-03-28 13:13 |
Indeed, quickly glancing over the error messages there's another small typo in https://github.com/python/cpython/blob/master/Modules/arraymodule.c#L2371: "array indices must be integer" -> "array indices must be integers" might as well fix that in your PR too (maybe also change the title to: "Fix small error message typos in arraymodule.c"?) | ||
msg290714 - (view) | Author: Jim Fasarakis-Hilliard (Jim Fasarakis-Hilliard) * | Date: 2017-03-28 13:24 |
..and another one here https://github.com/python/cpython/blob/master/Modules/arraymodule.c#L2145: "__reduce_ex__ argument should an integer" -> ".. should be .." | ||
msg290789 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2017-03-29 18:09 |
New changeset a90e64b78d74b80a7cbcca2237280c724b99431b by Brett Cannon (Sylvain) in branch 'master': bpo-29932: Fix small error message typos in arraymodule.c (GH-888) https://github.com/python/cpython/commit/a90e64b78d74b80a7cbcca2237280c724b99431b |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:58:44 | admin | set | github: 74118 |
2017-03-29 18:09:44 | brett.cannon | set | status: open -> closedresolution: fixedstage: resolved |
2017-03-29 18:09:24 | brett.cannon | set | nosy: + brett.cannonmessages: + |
2017-03-29 17:02:29 | SylvainDe | set | pull_requests: + <pull%5Frequest790> |
2017-03-28 13:24:57 | Jim Fasarakis-Hilliard | set | messages: + |
2017-03-28 13:13:09 | Jim Fasarakis-Hilliard | set | nosy: + Jim Fasarakis-Hilliardmessages: + |
2017-03-28 12:35:05 | SylvainDe | create |