Issue 30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader (original) (raw)

Created on 2017-05-04 22:24 by brett.cannon, last changed 2022-04-11 14:58 by admin.

Pull Requests
URL Status Linked Edit
PR 1735 open sayanchowdhury,2017-05-22 23:31
PR 26195 open zkneupper,2021-05-17 18:48
PR 27981 open python-dev,2021-08-26 19:45
Messages (6)
msg293022 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-04 22:24
https://docs.python.org/3/library/importlib.html#importlib.machinery.ExtensionFileLoader says "fullname, path" for __init__(), but https://github.com/python/cpython/blob/647c3d381e67490e82cdbbe6c96e46d5e1628ce2/Lib/importlib/_bootstrap_external.py#L909 says "name, path". While I would much rather change the parameter name to match the rest of the module, I don't think I'm comfortable with the backwards-compatibility breakage over just a single parameter name (although chances are no one will notice in either direction as everyone probably passes by position).
msg293122 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-05 16:34
Another option is to rename 'name' to 'fullname', make 'name' keyword-only, and then raise a DeprecationWarning if 'name' is used, eventually removing the keyword-only argument.
msg294193 - (view) Author: Sayan Chowdhury (sayanchowdhury) * Date: 2017-05-22 21:53
I am starting to work on this issue.
msg339886 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2019-04-10 19:37
I realized another solution to this is to make the argument positional-only, then the name simply doesn't matter. Probably unnecessary breakage, though.
msg393702 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-05-14 23:14
The PR was reviewed but it now has merge conflicts and possibly a test failure on MacOS.
msg400363 - (view) Author: Diana (DonnaDia) * Date: 2021-08-26 18:20
I want to work on it.
History
Date User Action Args
2022-04-11 14:58:46 admin set github: 74460
2021-08-26 19:45:24 python-dev set nosy: + python-devpull_requests: + <pull%5Frequest26429>
2021-08-26 18:20:10 DonnaDia set nosy: + DonnaDiamessages: +
2021-05-17 18:48:05 zkneupper set keywords: + patchnosy: + zkneupperpull_requests: + <pull%5Frequest24812>
2021-05-14 23:14:57 iritkatriel set title: Make importlib.abc.ExtensionFileLoader.__init__() documentation match code -> Rename 'name' to 'fullname' argument to ExtensionFileLoadercomponents: + Library (Lib), - Documentationkeywords: + easynosy: + iritkatrielversions: + Python 3.11, - Python 3.7, Python 3.8messages: +
2019-04-10 19:37:48 brett.cannon set messages: + versions: + Python 3.8
2017-07-23 23:56:36 berker.peksag set stage: needs patch -> patch reviewtype: enhancementversions: + Python 3.7
2017-05-22 23:31:00 sayanchowdhury set pull_requests: + <pull%5Frequest1826>
2017-05-22 21:53:26 sayanchowdhury set nosy: + sayanchowdhurymessages: +
2017-05-05 16:34:30 brett.cannon set messages: +
2017-05-04 22:24:49 brett.cannon create