Issue 30644: [EASY][doc] Document that signal.set_wakeup_fd(-1), unregister the previsouly set wakeup FD (original) (raw)

Issue30644

Created on 2017-06-13 07:45 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2149 merged pitrou,2017-06-13 08:17
PR 2140 merged pitrou,2017-06-13 08:18
PR 2150 merged pitrou,2017-06-13 08:18
PR 2151 merged pitrou,2017-06-13 08:18
Messages (3)
msg295859 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-13 07:48
The signal.set_wakeup_fd() function is used to write signal numbers as bytes into a pipe, to be able to handle signals using a "regular" file descriptors instead of special signal handlers. https://docs.python.org/dev/library/signal.html Problem: it's not documented how to unregister the FD. I just saw "signal.set_wakeup_fd(-1)" in a Pull Request and realized that we forgot to document it: https://github.com/python/cpython/pull/2139/ This issue is an EASY issue: please leave it to real newcomers who didn't write any PR to CPython previously. Core developers: explain how to fix the issue, don't fix it ;-) Doc/library/signal.rst should be modified. I read that it's even possible to create a PR using an online editor? I never tried: https://github.com/python/cpython/blob/master/Doc/library/signal.rst
msg295863 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2017-06-13 08:19
> This issue is an EASY issue: please leave it to real newcomers who didn't write any PR to CPython previously. Core developers: explain how to fix the issue, don't fix it ;-) Too late, sorry!
msg295864 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-13 08:20
> This issue is an EASY issue: please leave it to real newcomers who didn't write any PR to CPython previously. Core developers: explain how to fix the issue, don't fix it ;-) Oh wait, it seems like the core developer Antoine Pitrou fixed the issue before I created it! => commit d79c1d4a9406384f10a37f26a7515ce79f9fdd78 He already created 3 PR to backport the doc enhancement to 2.7, 3.5 and 3.6 branches. Sorry!
History
Date User Action Args
2022-04-11 14:58:47 admin set github: 74829
2017-06-13 08:38:21 pitrou set status: open -> closedstage: resolvedresolution: fixedversions: + Python 2.7, Python 3.5, Python 3.6
2017-06-13 08:20:16 vstinner set messages: +
2017-06-13 08:19:27 pitrou set nosy: + pitroumessages: +
2017-06-13 08🔞59 pitrou set pull_requests: + <pull%5Frequest2203>
2017-06-13 08🔞54 pitrou set pull_requests: + <pull%5Frequest2202>
2017-06-13 08🔞22 pitrou set pull_requests: + <pull%5Frequest2201>
2017-06-13 08:17:59 pitrou set pull_requests: + <pull%5Frequest2200>
2017-06-13 07:48:51 vstinner set messages: +
2017-06-13 07:46:00 vstinner create