Issue 30962: Add caching to logging.Logger.isEnabledFor() (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/75145

classification

process

Created on 2017-07-18 20:24 by aviso, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg298612 - (view)	Author: Avram (aviso) *	Date: 2017-07-18 20:24
Checking to see if a log level is enabled can add non-insignificant time to programs with a large number of logging statements. This issue is to track a pull request which introduces caching to the logging module so checking to see if a log level is enabled takes half the current time. Benchmark code is in the referenced pull request
msg298613 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2017-07-18 20:34
Does this speed up actual logging calls such logger.info, etc?
msg298614 - (view)	Author: Avram (aviso) *	Date: 2017-07-18 20:44
Yes, though the bottleneck for normal logging is more likely in other areas so the speedup will be less noticeable. Where I notice it is with debug statements when debugging is disabled. In that scenario the bulk of the time is spent checking if the level is enabled anywhere in the ancestry.
msg298615 - (view)	Author: STINNER Victor (vstinner) *	Date: 2017-07-18 20:45
>> Benchmark code is in the referenced pull request > Does this speed up actual logging calls such logger.info, etc? According to the benchmark in the PR, it's 50% faster when the log is ignored, like a debug call in production.
msg299494 - (view)	Author: Vinay Sajip (vinay.sajip) *	Date: 2017-07-30 09:36
New changeset 78c18a9b9a1445f7c755929917a790ba02b4a5e0 by Vinay Sajip (Avram Lubkin) in branch 'master': bpo-30962: Added caching to Logger.isEnabledFor() (GH-2752) https://github.com/python/cpython/commit/78c18a9b9a1445f7c755929917a790ba02b4a5e0