Issue 31001: IDLE: Add tests for configdialog highlight tab (original) (raw)

Issue31001

Created on 2017-07-24 07:22 by terry.reedy, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2908 merged terry.reedy,2017-07-27 07:56
PR 3123 merged cheryl.sabella,2017-08-17 19:18
PR 3124 merged terry.reedy,2017-08-18 00:40
Messages (7)
msg299596 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-01 04:59
Pr2908 originally just sorted highlight methods together, but was extended to sort all methods together and relabeled for #31060. (This actually simplified the diff.) Pr2925, the 3.6 backport, appears on the replacement issue.
msg300276 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-15 01:32
If we do the same renamings for the theme selection vars and functions as done for keys selection on the keys tab, then the corresponding tests can be copied and slightly altered. However, duplicate names require that KeyPage be separated first. Hence the dependency. When the current mess is replaced on both pages, we *might* be able to make a simple Frame subclass tested once and used on both pages.
msg300351 - (view) Author: Cheryl Sabella (cheryl.sabella) * (Python committer) Date: 2017-08-16 11:43
Working on this now.
msg300463 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-17 23:56
Coverage now 95%. We are getting close. Still not covered in highlight group: create_page_highlight: # Highlight only. text.bind('', lambda e: 'break') text.bind('', lambda e: 'break') Callbacks are never called. I presume that these mask something. I am not sure that they are needed. save_new: # Same as for keys. if not idleConf.userCfg['highlight'].has_section(theme_name): Never false. delete_custom: # Same as for keys. if not item_list: self.custom_theme_on['state'] = DISABLED self.customlist.SetMenu(item_list, '- no custom themes -') else: self.customlist.SetMenu(item_list, item_list[0]) Condition never false, else never executed.
msg300464 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-18 00:39
New changeset 82aff62462e65077a6614b466c986f93a601c33d by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31001: IDLE: Add tests for configdialog highlight tab (#3123) https://github.com/python/cpython/commit/82aff62462e65077a6614b466c986f93a601c33d
msg300466 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-18 01:02
New changeset 6db2edbe050cc9ac9026f350a24f2d525bcadecd by Terry Jan Reedy in branch '3.6': [3.6] bpo-31001: IDLE: Add tests for configdialog highlight tab (GH-3123) (#3124) https://github.com/python/cpython/commit/6db2edbe050cc9ac9026f350a24f2d525bcadecd
msg300467 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-18 01:03
Another big thank you.
History
Date User Action Args
2022-04-11 14:58:49 admin set github: 75184
2017-08-18 01:03:29 terry.reedy set messages: +
2017-08-18 01:03:13 terry.reedy set status: open -> closedresolution: fixedstage: needs patch -> resolved
2017-08-18 01:02:23 terry.reedy set messages: +
2017-08-18 00:40:53 terry.reedy set pull_requests: + <pull%5Frequest3162>
2017-08-18 00:39:03 terry.reedy set messages: +
2017-08-17 23:56:47 terry.reedy set messages: +
2017-08-17 19🔞01 cheryl.sabella set pull_requests: + <pull%5Frequest3161>
2017-08-16 11:43:59 cheryl.sabella set messages: +
2017-08-15 01:49:11 terry.reedy link issue31206 dependencies
2017-08-15 01:32:33 terry.reedy set nosy: + cheryl.sabelladependencies: + IDLE, configdialog: Factor out KeysPage class from ConfigDialogmessages: +
2017-08-01 04:59:48 terry.reedy set messages: +
2017-07-27 07:56:16 terry.reedy set pull_requests: + <pull%5Frequest2959>
2017-07-24 08:05:37 terry.reedy link issue30780 dependencies
2017-07-24 07:22:14 terry.reedy create