Issue 31018: _tracemalloc frame_t packing optimization not working in Windows x64 (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/75201

classification

Title: _tracemalloc frame_t packing optimization not working in Windows x64
Type: enhancement Stage: resolved
Components: Extension Modules, Windows Versions: Python 3.7, Python 3.6, Python 3.5

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Segev Finer, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Priority: normal Keywords:

Created on 2017-07-24 17:20 by Segev Finer, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2848 merged Segev Finer,2017-07-24 17:23
PR 2492 merged Segev Finer,2017-07-24 17:43
PR 2868 merged Segev Finer,2017-07-25 16:34
PR 2869 merged Segev Finer,2017-07-25 16:34
Messages (5)
msg298999 - (view) Author: Segev Finer (Segev Finer) * Date: 2017-07-24 17:20
..\Modules\_tracemalloc.c(88): warning C4359: '': Alignment specifier is less than actual alignment (8), and will be ignored. For this to actually work we simply need to use #pragma pack instead.
msg299046 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-25 08:47
New changeset 39243779f4c97ec6f700fa73c007ca66dfa9408e by Victor Stinner (Segev Finer) in branch 'master': bpo-31018: Switch to #pragma pack from __declspec(align) (#2848) https://github.com/python/cpython/commit/39243779f4c97ec6f700fa73c007ca66dfa9408e
msg299121 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-25 17:20
New changeset d8b5216f998bbb0f921815165f46918b86620ab7 by Victor Stinner (Segev Finer) in branch '3.6': [3.6] bpo-31018: Switch to GH-pragma pack from __declspec(align) (GH-2848) (#2868) https://github.com/python/cpython/commit/d8b5216f998bbb0f921815165f46918b86620ab7
msg299122 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-25 17:20
New changeset 49175b3b670a4514b5dc5dcf7b58203d2be852c1 by Victor Stinner (Segev Finer) in branch '3.5': [3.5] bpo-31018: Switch to GH-pragma pack from __declspec(align) (GH-2848) (#2869) https://github.com/python/cpython/commit/49175b3b670a4514b5dc5dcf7b58203d2be852c1
msg299123 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-25 17:21
Thanks for the fix ;-)
History
Date User Action Args
2022-04-11 14:58:49 admin set github: 75201
2017-07-25 17:21:25 vstinner set status: open -> closedresolution: fixedmessages: + stage: resolved
2017-07-25 17:20:53 vstinner set messages: +
2017-07-25 17:20:41 vstinner set messages: +
2017-07-25 16:34:43 Segev Finer set pull_requests: + <pull%5Frequest2920>
2017-07-25 16:34:41 Segev Finer set pull_requests: + <pull%5Frequest2919>
2017-07-25 08:49:13 vstinner set versions: - Python 3.4
2017-07-25 08:47:48 vstinner set messages: +
2017-07-25 07:50:34 pitrou set nosy: + vstinner
2017-07-24 17:43:27 Segev Finer set pull_requests: + <pull%5Frequest2897>
2017-07-24 17:25:52 Segev Finer set pull_requests: - <pull%5Frequest2896>
2017-07-24 17:23:38 Segev Finer set pull_requests: + <pull%5Frequest2896>
2017-07-24 17:23:09 Segev Finer set pull_requests: + <pull%5Frequest2895>
2017-07-24 17:20:41 Segev Finer create