Issue 31258: [2.7] Enhance support reap_children() and threading_cleanup() (original) (raw)

Issue31258

Created on 2017-08-22 14:36 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 3182 closed vstinner,2017-08-22 14:38
PR 3183 merged vstinner,2017-08-22 14:39
PR 3184 merged vstinner,2017-08-22 14:40
Messages (5)
msg300695 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-08-22 14:36
Backport reap_children() and threading_cleanup() enhancements from master to 2.7 to make tests more reliables, reduce random failures on Python CIs.
msg300696 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-08-22 14:48
Using PR 3182, test_socketserver fails with --fail-env-changed because of bpo-31151 "socketserver.ForkingMixIn.server_close() leaks zombie processes".
msg300698 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-08-22 14:51
New changeset 1460ce5a9325690d8a1913c296a9bba437ff0f39 by Victor Stinner in branch '2.7': bpo-31258: test_signal: call waitpid() to prevent zombie process (#3183) https://github.com/python/cpython/commit/1460ce5a9325690d8a1913c296a9bba437ff0f39
msg300699 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-08-22 14:51
New changeset 02e03672e6766b1da847b1635982a70346780744 by Victor Stinner in branch '2.7': bpo-31258: test_urllib2_localnet uses addCleanup(server.stop) (#3184) https://github.com/python/cpython/commit/02e03672e6766b1da847b1635982a70346780744
msg302018 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-09-13 00:52
While backporting fixes on tests make sense, I'm not sure that it's doable to make regrtest more strict. It took me a while to fix all "dangling threads" and "dangling processes" on the master branch, and 6 months later, I'm not done yet. There are tricky issues the socketserver module (bpo-31233, bpo-31151). So I prefer to abandon this issue, and only backport test fixes.
History
Date User Action Args
2022-04-11 14:58:51 admin set github: 75441
2017-09-13 00:52:24 vstinner set status: open -> closedresolution: rejectedmessages: + stage: resolved
2017-08-22 15:07:03 vstinner set pull_requests: - <pull%5Frequest3224>
2017-08-22 15:05:24 vstinner set pull_requests: + <pull%5Frequest3224>
2017-08-22 14:51:22 vstinner set messages: +
2017-08-22 14:51:11 vstinner set messages: +
2017-08-22 14:48:34 vstinner set messages: +
2017-08-22 14:40:57 vstinner set pull_requests: + <pull%5Frequest3222>
2017-08-22 14:39:07 vstinner set pull_requests: + <pull%5Frequest3221>
2017-08-22 14:38:05 vstinner set pull_requests: + <pull%5Frequest3220>
2017-08-22 14:36:08 vstinner create