Issue 3161: Missing import for sys in _abcoll (original) (raw)

Issue3161

Created on 2008-06-21 15:55 by hodgestar, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
abcoll-hash.diff hodgestar,2008-06-21 15:55
Messages (3)
msg68504 - (view) Author: Simon Cross (hodgestar) Date: 2008-06-21 15:55
The _hash method of the Set ABC uses sys.maxsize but doesn't import sys. The attached patch (against trunk) imports sys and adds a test to show the problem. There are also still some other _abcoll.py cleanups waiting in issue 2226.
msg68506 - (view) Author: Simon Cross (hodgestar) Date: 2008-06-21 15:57
One could also make a case for simply removing the _hash method since it doesn't look like anything is using it? And anything that was using it would already be broken?
msg68605 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2008-06-23 03:30
Applied in r64475 . Thanks for the patch.
History
Date User Action Args
2022-04-11 14:56:35 admin set github: 47411
2008-06-23 03:30:09 rhettinger set status: open -> closedresolution: acceptedmessages: +
2008-06-23 00:46:45 benjamin.peterson set assignee: rhettingernosy: + rhettinger
2008-06-21 15:57:59 hodgestar set messages: +
2008-06-21 15:55:54 hodgestar create