Issue 3183: sha modules & Modules/Setup.dist (original) (raw)

It would be very useful to add two lines to Modules/Setup.dist:

Index: Modules/Setup.dist

--- Modules/Setup.dist (revision 64489) +++ Modules/Setup.dist (working copy) @@ -249,6 +249,8 @@

The _sha module implements the SHA checksum algorithm.

(NIST's Secure Hash Algorithm.)

#_sha shamodule.c +#_sha256 sha256module.c +#_sha512 sha512module.c

SGI IRIX specific modules -- off by default.

Background:

• Python built on machine A and distributed to end-users. Machine A happens to have the OpenSSL libraries.

• End-user runs our package incl. the pre-built Python on machine B, which happens not to have the OpenSSL libraries, or an incompatible version.

• hashlib imports _hashlib, which fails because of the OpenSSL problem.

• hashlib tries to fall back to generic sha and md5 modules. I had _sha and md5 enabled in Modules/Setup.dist, but didn't know Python 2.5 needs more.

I found this out the hard way. It would be helpful to at least have the extra two comments as suggested above. I think it would be even better to not comment out the md5 and sha modules in the original Python distribution since it just adds about 200k of .o files (Linux). That's very cheap compared to the loss in time if people have to figure out why import hashlib is failing and how to work around the problem.